1006[BUGFIX] No image generation with PHP-SAFE_MODE (GM/IM)
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 3
Review log 7
-
Dmitry Dulepov commented on patch set 1 04/03/11, 08:57
It would be cleaner to use \s instead of [[:space:]] with preg_* functions. This is near lines 95 and 114 at class.t3lib_utility_command.php, line 410 in thumb.php, line 2676 in class.t3lib_stdgraphic.php. -
Helmut Hummel commented on patch set 1 04/03/11, 08:57
I would prefer that you didn't submit this Patch in general lloks good, but the bug number in the commit message is wrongThis is a wrong bug number. Could you please correct it? -
Steffen Ritter commented on patch set 1 04/03/11, 08:57
Looks good to me, approved looks - after you explained the stuff with setting the locales :) -
Chris topher commented on patch set 1 04/03/11, 08:57
Looks good to me, but someone else must approve This is a test, ignore it. I did _not_ review the code and will take this vote away again in a minute. -
Jigal van Hemert commented on patch set 1 04/03/11, 08:57
The character class [:space:] includes the VT character, which is missing from \s (for Perl compatibility). See http://www.php.net/manual/en/regexp.reference.character-classes.php -
Marcus Krause commented on patch set 1 04/03/11, 08:57
I would prefer that you didn't submit this Would you please fix the code comments like outlined in the inline comments?class.t3lib_stdgraphic.php:2674the comment does not match the actual code (logical OR vs logical AND)thumbs.php:408the comment does not match the actual code (logical OR vs logical AND)class.t3lib_utility_command.php:93the comment does not match the actual code (logical OR vs logical AND)class.t3lib_utility_command.php:112the comment does not match the actual code (logical OR vs logical AND) -
Jigal van Hemert commented on patch set 1 04/03/11, 08:57
Abandoned safe_mode support is dropped in 4.6; no need to have this change in master anymore.