Review main Merged

10065[BUGFIX] Make alphanum. filter work with umlauts

Andreas Lappe CR +2 V +2 Normal +78 −1 updated 06/03/13, 20:49

Commit message

Changes the regular expression used to validate the string into a
unicode-aware character-class and adds two tests for this.

Review

  • Code review CR +2
    • Andreas Wolf +2
  • Verified V +2
    • Andreas Wolf +2

Files 2

Review log 6

  1. Andreas Wolf merged patch set 1 04/01/12, 12:17

  2. Andreas Wolf commented on patch set 2 V 0 04/01/12, 12:17

    by team member; Looks good to me, approved Merging after my review as this is a rather trivial change and covered by a working unit test.
  3. Andreas Lappe uploaded patch set 2 04/01/12, 12:17

  4. Mr. Jenkins commented on patch set 1 04/01/12, 12:17

  5. Mr. Jenkins commented on patch set 2 04/01/12, 12:17

  6. Oliver Hader commented on patch set 2 04/01/12, 12:17

    (1 inline comment)

    AlphanumericTest.php:6

    Hmmm...