Review main Merged

10066[BUGFIX] Make alphabetic filter work with umlauts

Andreas Lappe CR +2 V +2 Normal +78 −1 updated 06/03/13, 20:49

Commit message

Changes the regular expression used to validate the string into a
unicode-aware character-class and adds two testcases for this.

Review

  • Code review CR +2
    • Andreas Wolf +2
  • Verified V +2
    • Andreas Wolf +2

Files 2

Review log 6

  1. Andreas Wolf merged patch set 1 04/01/12, 12:16

  2. Andreas Wolf commented on patch set 2 V 0 04/01/12, 12:16

    by team member; Looks good to me, approved Merging after my review because this change is rather trivial and covered by a working unit test.
  3. Andreas Lappe uploaded patch set 2 04/01/12, 12:16

  4. Mr. Jenkins commented on patch set 1 04/01/12, 12:16

  5. Mr. Jenkins commented on patch set 2 04/01/12, 12:16

  6. Oliver Hader commented on patch set 2 04/01/12, 12:16

    (2 inline comments)
    ext:form was introduced with 4.6 - 4.5 is wrong here...

    AlphabeticTest.php:6

    Hmmm...