Review TYPO3_4-5 Abandoned

10091[BUGFIX] Shortcuts within mounted trees lose MP parameter

Andreas Wolf CR 0 V 0 Easy +31 −13 updated 07/22/13, 16:01

Commit message

When mounting a tree which has shortcut pages in it, a link to such a
shortcut page has the MP parameter in it. But when redirecting to the
destination page of the shortcut, this MP parameter is lost, thus making
the page lose its connection to the tree root (or rather to the part of
the rootline above the mountpoint).

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 3

  1. Andreas Wolf commented on patch set 1 05/27/13, 17:19

    Yes: I found this error on 4.5 and thought that it was not present on newer versions because there the shortcuts are resolved for menus, with preserved MP parameter - the problem is "only" present when directly calling the URL of the shortcut itself.
  2. Markus Klein commented on patch set 1 05/27/13, 17:19

    I would prefer that you didn't submit this Any specific reason why you pushed to old branch first?
  3. Ernesto Baschny abandoned the change 07/22/13, 16:01

    I'll abandoning this review until the master patch is "ready" and merged.