Review main Merged

1010[FEATURE] Sort plugin names in BE form alphabetically

Dmitry Dulepov CR +2 V +1 Easy +8 −1 updated 06/03/13, 20:49

Commit message

Review

  • Code review CR +2
    • Andreas Wolf +2
  • Verified V +1
    • Andreas Wolf +1

Files 1

Review log 10

  1. Gerrit wrote 03/07/11, 14:09

    Your change could not be merged due to a path conflict. Please merge (or rebase) the change locally and upload the resolution for review.
  2. Andreas Wolf commented on patch set 1 03/07/11, 14:09

    Verified; Looks good to me, approved Read and tested. This should be integrated differently into the refactored TCEforms. I will open an issue for it.
  3. Andreas Wolf commented on patch set 2 03/07/11, 14:09

    Verified; Looks good to me, approved Just cherry-picked to current master, applied without any hassle.
  4. Andreas Wolf uploaded patch set 2 03/07/11, 14:09

  5. Dmitry Dulepov commented on patch set 1 03/07/11, 14:09

    Why hacky? It sorts items using PHP function and proper TYPO3 API :) The patch was only for BE forms. New content element wizard is a different place and it may not appear here. It must be a separate patch.
  6. Dmitry Dulepov commented on patch set 1 03/07/11, 14:09

    If you are interested in that user function, you can have a look to the "TYPO3 core API". It describes that itemProcFunc is used to manipulate the array of items. This is the only official way :)
  7. Dmitry Dulepov commented on patch set 1 03/07/11, 14:09

    Please, see this screenshot to get the idea of what it means: http://bugs.typo3.org/file_download.php?file_id=15484&type=bug
  8. Philipp Gampe commented on patch set 1 V 0 03/07/11, 14:09

    This solution looks a little hacky. Also this does not solve the same problem for new content element wizard.
  9. Philipp Gampe commented on patch set 1 03/07/11, 14:09

    Using a user function feels strange. Anyway, I do not have enough insight to judge whether this is a good way to do it - I have no alternative way either. I keep my verified vote +1 and no vote for code review. Someone with more experience (than me) should vote :)
  10. Andreas Wolf merged patch set 2 03/07/11, 14:09