Review TYPO3_4-7 Abandoned

10101[BUGFIX] Shortcuts within mounted trees lose MP parameter

Andreas Wolf CR 0 V 0 Easy +35 −13 updated 07/05/13, 12:12

Commit message

When mounting a tree which has shortcut pages in it, a link to such a
shortcut page has the MP parameter in it. But when redirecting to the
destination page of the shortcut, this MP parameter is lost, thus making
the page lose its connection to the tree root (or rather to the part of
the rootline above the mountpoint).

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 7

  1. Andreas Wolf commented on patch set 1 05/27/13, 17:19

    Could you do a first review for master then? For 4.7 we'll have to wait for 4.7.1 anyways.
  2. Stefan Neufeind commented on patch set 1 05/27/13, 17:19

    No score Hmm, turns out you are right. Sorry for that. I must have mixed up browser-tabs while investigating the merge-status in master.
  3. Stefan Neufeind commented on patch set 1 05/27/13, 17:19

    Looks good to me, but someone else must approve merged in master. Philipp, could you maybe remove your -1?
  4. Helmut Hummel commented on patch set 1 05/27/13, 17:19

    I would prefer that you didn't submit this @Stefan: can you show me the commit hash of that change in master? This one is obviously not merged: https://review.typo3.org/#/c/10100/
  5. Philipp Gampe commented on patch set 1 05/27/13, 17:19

    No score
  6. Philipp Gampe commented on patch set 1 05/27/13, 17:19

    I would prefer that you didn't submit this not yet merged in master
  7. Steffen Ritter abandoned the change 07/05/13, 12:12

    Only Security Fixes for TYPO3 4.7