10109[BUGFIX] Improve usability of new Media element flexform
Commit message
Review
-
Code review CR +2
- Steffen Ritter +2
- Markus Klein +1
- Dominik Mathern +1
-
Verified V +2
- Steffen Ritter +2
- Markus Klein +1
- Dominik Mathern +1
Files 3
Review log 11
-
Steffen Ritter uploaded patch set 2 04/10/12, 12:45
-
Oliver Klee commented on patch set 3 04/10/12, 12:45
(4 inline comments) Going to push an updated patch in a minute.flexform_media.xml:40This should be "num" instead of "int" so no negative numbers can be entered.flexform_media.xml:51Ditto.locallang_ttc.xlf:829This should be without the hyphen.locallang_ttc.xlf:832Ditto. -
Markus Klein commented on patch set 4 04/10/12, 12:45
Verified; Looks good to me, but someone else must approve -
Oliver Klee uploaded patch set 4 04/10/12, 12:45
-
Steffen Ritter uploaded patch set 3 04/10/12, 12:45
-
Steffen Ritter commented on patch set 3 04/10/12, 12:45
just removed dependencies -
Steffen Ritter commented on patch set 4 V 0 04/10/12, 12:45
by team member; Looks good to me, approved -
Steffen Ritter merged patch set 4 04/10/12, 12:45
-
Jigal van Hemert commented on patch set 2 04/10/12, 12:45
Verified; Looks good to me, but someone else must approve -
Dominik Mathern commented on patch set 4 04/10/12, 12:45
Verified; Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 4 04/10/12, 12:45
This needs to be ported/pushed to master!