Review main Abandoned

10112[BUGFIX] EXT:form cannot handle validation for more than one form per page

Andreas Wolf CR 0 V 0 Normal +38 −18 updated 09/14/13, 10:51

Commit message

If multiple forms are used on the same page with different validation
rules, all validation rules apply to all forms due to
'tx_form_System_Validate' being a singleton. This results in most forms
never validating properly.

The problem is fixed by making the class a prototype class, thus making
it possible to have its own instance for each form object.

Additionally, this patch makes the naming a bit clearer (rulesClass ->
validator)

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 8

  1. Stefan Neufeind commented on patch set 1 05/27/13, 17:19

    (1 inline comment) Still valid or already resolved by the other patch?
    and 4.7?
  2. Stefan Neufeind commented on patch set 1 05/27/13, 17:19

    4.7 for sure. @Philipp: I don't see any open one. But you might be thinking of http://review.typo3.org/6624 which is already merged.
  3. Stefan Neufeind commented on patch set 1 05/27/13, 17:19

    Andreas, please see the other patch that was already merged. Is this here still neeeded or could it be abandoned? Please also be sure to update the forge-issue accordingly!
  4. Philipp Gampe commented on patch set 1 05/27/13, 17:19

    Yes, exactly this one. What is the difference. It would be good to have test instructions (or even the test forms as t3x) in the issue.
  5. Philipp Gampe commented on patch set 1 05/27/13, 17:19

    Branch 4.7? I remember a patch fixing this?! Does it still not work?
  6. Mr. Jenkins commented on patch set 1 05/27/13, 17:19

  7. Stefan Neufeind commented on patch set 1 08/26/13, 19:08

    Andreas, please comment!
  8. Andreas Wolf abandoned the change 09/14/13, 10:51

    Abandoned because the main issue has been fixed. The naming change could be ported, but I currently don't have time for that.