Review main Merged

10115[TASK] Remove page related icons from docHeader in page/list

Felix Kopp CR +2 V +2 Easy +0 −41 updated 06/03/13, 20:49

Commit message

Removes page action related icons from the docHeader in work area
within page module:

* Create new page
* Move page
* Page history

and within list module:

* Up one level
* Hide/unhide
* Move page

Also removes "New content element" from page, these are added to columns.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Tolleiv Nietsch +1
  • Verified V +2
    • Georg Ringer +2
    • Tolleiv Nietsch +1

Files 2

Review log 11

  1. Stefan Galinski commented on patch set 2 05/08/12, 15:38

    Fails; I would prefer that you didn't submit this The patch doesn't applies anymore in master and also you should remove 4.7 from the releases line.
  2. Felix Kopp uploaded patch set 2 05/08/12, 15:38

  3. Felix Kopp commented on patch set 2 05/08/12, 15:38

    Please support this patchset.
  4. Tolleiv Nietsch commented on patch set 3 05/08/12, 15:38

    Verified; Looks good to me, but someone else must approve Hm not sure I like this change ... but obviously it's for consistency.
  5. Felix Kopp commented on patch set 3 05/08/12, 15:38

    The concept is accepted by UI/UX team. Please review this patch - would like to see the patch merged.
  6. Felix Kopp uploaded patch set 3 05/08/12, 15:38

  7. Felix Kopp commented on patch set 3 05/08/12, 15:38

    Thanks Stefan, didn't realize that the patch could not be applied. Fixed that now :)
  8. Mr. Jenkins commented on patch set 2 05/08/12, 15:38

  9. Mr. Jenkins commented on patch set 3 05/08/12, 15:38

  10. Georg Ringer commented on patch set 3 V 0 05/08/12, 15:38

    by team member; Looks good to me, approved
  11. Georg Ringer merged patch set 3 05/08/12, 15:38