Review main Merged

1012[BUGFIX] Drop the checks for the image file size from the install tool

Oliver Klee CR +2 V +1 Normal +2 −51 updated 06/03/13, 20:49

Commit message

The file sizes of the generated images in the install tool may somewhat differ in size while
the images are perfectly fine. Thus these checks do not provide helpful information, but
produce false warnings. This change removes this image file size check.

Review

  • Code review CR +2
    • Dmitry Dulepov +2
    • Oliver Klee +1
    • Christian Müller +1
    • Arvid Jakobsson +1
    • Philipp Gampe +1
  • Verified V +1
    • Dmitry Dulepov +1
    • Philipp Gampe +1

Files 2

Review log 9

  1. Dmitry Dulepov commented on patch set 1 03/04/11, 10:13

    (1 inline comment)
  2. Christian Müller commented on patch set 1 03/04/11, 10:13

    (1 inline comment) See comment.

    class.tx_install.php:5187

    Does it make sense to keep it at all? I would just remove the substituteSubpart or did I miss something?
  3. Oliver Klee commented on patch set 2 03/04/11, 10:13

    Looks good to me, but someone else must approve
  4. Christian Müller commented on patch set 2 03/04/11, 10:13

    Looks good to me, but someone else must approve
  5. Philipp Gampe uploaded patch set 2 03/04/11, 10:13

  6. Philipp Gampe commented on patch set 2 03/04/11, 10:13

    Verified; Looks good to me, but someone else must approve I just removed the lines mentioned by Christian and Dmitry and pushed a new changeset.
  7. Arvid Jakobsson commented on patch set 2 03/04/11, 10:13

    Looks good to me, but someone else must approve

    class.tx_install.php:6746

    You can quite easily remove extraneous whitespace changes from your patch, using interactive adding in git. See http://book.git-scm.com/4_interactive_adding.html for example :)
  8. Dmitry Dulepov commented on patch set 2 03/04/11, 10:13

    Verified; Looks good to me, approved I reviewed the code and tested the Install tool. All works fine, approved.
  9. Dmitry Dulepov merged patch set 2 03/04/11, 10:13