1012[BUGFIX] Drop the checks for the image file size from the install tool
Commit message
Review
-
Code review CR +2
- Dmitry Dulepov +2
- Oliver Klee +1
- Christian Müller +1
- Arvid Jakobsson +1
- Philipp Gampe +1
-
Verified V +1
- Dmitry Dulepov +1
- Philipp Gampe +1
Files 2
Review log 9
-
Dmitry Dulepov commented on patch set 1 03/04/11, 10:13
(1 inline comment) -
Christian Müller commented on patch set 1 03/04/11, 10:13
(1 inline comment) See comment.class.tx_install.php:5187Does it make sense to keep it at all? I would just remove the substituteSubpart or did I miss something? -
Oliver Klee commented on patch set 2 03/04/11, 10:13
Looks good to me, but someone else must approve -
Christian Müller commented on patch set 2 03/04/11, 10:13
Looks good to me, but someone else must approve -
Philipp Gampe uploaded patch set 2 03/04/11, 10:13
-
Philipp Gampe commented on patch set 2 03/04/11, 10:13
Verified; Looks good to me, but someone else must approve I just removed the lines mentioned by Christian and Dmitry and pushed a new changeset. -
Arvid Jakobsson commented on patch set 2 03/04/11, 10:13
Looks good to me, but someone else must approveclass.tx_install.php:6746You can quite easily remove extraneous whitespace changes from your patch, using interactive adding in git. See http://book.git-scm.com/4_interactive_adding.html for example :) -
Dmitry Dulepov commented on patch set 2 03/04/11, 10:13
Verified; Looks good to me, approved I reviewed the code and tested the Install tool. All works fine, approved. -
Dmitry Dulepov merged patch set 2 03/04/11, 10:13