10206[BUGFIX] tx_form_System_Localization needs a parameter
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 1
Review log 12
-
Tolleiv Nietsch commented on patch set 1 05/27/13, 17:19
I would prefer that you didn't submit this There are 6 places in the Core were this would be needed. Imho it would make more sense to use an empty string as default value for that parameter. -
Oliver Klee commented on patch set 1 05/27/13, 17:19
Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 1 05/27/13, 17:19
It would be cool if somebody could check for side effects, I think this should have issued a warning all time long. -
Stefan Neufeind commented on patch set 2 05/27/13, 17:19
still valid? meanwhile it has a default in 6.0: public function __construct($localLanguageFile = 'LLL:EXT:form/Resources/Private/Language/locallang_controller.xml') -
Stefan Neufeind commented on patch set 2 05/27/13, 17:19
might still be needed for the older branches though -
Philipp Gampe uploaded patch set 2 05/27/13, 17:19
-
Andy Grunwald commented on patch set 1 05/27/13, 17:19
Verified; Looks good to me, but someone else must approve After testing, i didn`t see problems with this change. -
Andy Grunwald commented on patch set 2 05/27/13, 17:19
Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 2 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6043/ : SUCCESS -
Wouter Wolters commented on patch set 1 05/27/13, 17:19
Looks good to me, but someone else must approve -
Wouter Wolters commented on patch set 2 05/28/13, 18:52
I would prefer that you didn't submit this IMO not valid anymore and not a big issue in 4.7, abandon? -
Mathias Schreiber abandoned the change 12/13/14, 10:59
fixed in both 7 and 6.2