Review main Abandoned

10206[BUGFIX] tx_form_System_Localization needs a parameter

Philipp Gampe CR 0 V 0 Easy +1 −1 updated 12/13/14, 10:59

Commit message

Currently \TYPO3\CMS\Form\Localization->__construct needs a locallang
file as parameter. This is not needed and some call do not specify a
parameter.
Solution: Make the parameter optional.

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 12

  1. Tolleiv Nietsch commented on patch set 1 05/27/13, 17:19

    I would prefer that you didn't submit this There are 6 places in the Core were this would be needed. Imho it would make more sense to use an empty string as default value for that parameter.
  2. Oliver Klee commented on patch set 1 05/27/13, 17:19

    Looks good to me, but someone else must approve
  3. Philipp Gampe commented on patch set 1 05/27/13, 17:19

    It would be cool if somebody could check for side effects, I think this should have issued a warning all time long.
  4. Stefan Neufeind commented on patch set 2 05/27/13, 17:19

    still valid? meanwhile it has a default in 6.0: public function __construct($localLanguageFile = 'LLL:EXT:form/Resources/Private/Language/locallang_controller.xml')
  5. Stefan Neufeind commented on patch set 2 05/27/13, 17:19

    might still be needed for the older branches though
  6. Philipp Gampe uploaded patch set 2 05/27/13, 17:19

  7. Andy Grunwald commented on patch set 1 05/27/13, 17:19

    Verified; Looks good to me, but someone else must approve After testing, i didn`t see problems with this change.
  8. Andy Grunwald commented on patch set 2 05/27/13, 17:19

    Looks good to me, but someone else must approve
  9. Mr. Jenkins commented on patch set 2 05/27/13, 17:19

  10. Wouter Wolters commented on patch set 1 05/27/13, 17:19

    Looks good to me, but someone else must approve
  11. Wouter Wolters commented on patch set 2 05/28/13, 18:52

    I would prefer that you didn't submit this IMO not valid anymore and not a big issue in 4.7, abandon?
  12. Mathias Schreiber abandoned the change 12/13/14, 10:59

    fixed in both 7 and 6.2