Review main Merged

10210[FEATURE] Add method to convert integer to version number

Markus Klein CR +2 V +2 Normal +64 −9 updated 06/03/13, 20:49

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Andy Grunwald +1
  • Verified V +2
    • Christian Kuhn +2
    • Andy Grunwald +1

Issues 1

Files 2

Review log 19

  1. Markus Klein uploaded patch set 2 04/11/12, 09:24

  2. Oliver Klee commented on patch set 2 1 comment 04/11/12, 09:24

    I would prefer that you didn't submit this
  3. Christian Kuhn commented on patch set 2 04/11/12, 09:24

    I would prefer that you didn't submit this -1 until the new method is covered with unit tests.
  4. Philipp Gampe commented on patch set 2 04/11/12, 09:24

    (1 inline comment)

    class.t3lib_utility_versionnumber.php:47

    whitespace :)
  5. Andy Grunwald commented on patch set 2 04/11/12, 09:24

    I would prefer that you didn't submit this I will add some unit tests. A new patch set will follow very soon.
  6. Christian Kuhn uploaded patch set 4 04/11/12, 09:24

  7. Christian Kuhn commented on patch set 4 04/11/12, 09:24

    Verified; Looks good to me, but someone else must approve
  8. Andy Grunwald commented on patch set 3 04/11/12, 09:24

    This is a nice small feature, but why you return FALSE if the version (integer) is lower than 1000000? If you have a look at the unit test t3lib_utility_VersionNumberTest, the version (integer) 1012 should be 0.1.12. With checking the integer version is lower than 1000000 this doesn`t work. With the new patch set, this example will work. The other switches are: - throw a exception instead of returning false - add unit tests for this new method - make the check if the argument is an integer absolute
  9. Andy Grunwald uploaded patch set 3 04/11/12, 09:24

  10. Andy Grunwald commented on patch set 4 04/11/12, 09:24

    Verified; Looks good to me, but someone else must approve
  11. Christian Kuhn commented on patch set 5 04/11/12, 09:24

    Andy, it seems you reverted all my changes of change set #4. Would you like to take a look again?
  12. Andy Grunwald commented on patch set 5 04/11/12, 09:24

    I revieved an email from Michael Schams with some small document changes. In the last change there was a doc header mistake. Here are the changes of patch set: * Change the word "if" to lowercase * Change "a integer" to "an integer"
  13. Andy Grunwald uploaded patch set 5 04/11/12, 09:24

  14. Andy Grunwald uploaded patch set 6 04/11/12, 09:24

  15. Andy Grunwald commented on patch set 6 04/11/12, 09:24

    Verified; Looks good to me, but someone else must approve
  16. Wouter Wolters commented on patch set 4 04/11/12, 09:24

    Verified; Looks good to me, but someone else must approve

    class.t3lib_utility_versionnumber.php:56

    space after if
  17. Wouter Wolters commented on patch set 5 1 comment 04/11/12, 09:24

    Verified; Looks good to me, but someone else must approve see inline comment
  18. Christian Kuhn commented on patch set 6 V 0 04/11/12, 09:24

    by team member; Looks good to me, approved
  19. Christian Kuhn merged patch set 6 04/11/12, 09:24