Review main Merged

10224[FEATURE] Ask for old password when changing

Georg Ringer CR +2 V +2 Normal +64 −18 updated 03/09/15, 15:14

Commit message

Following security best practices, a user should
to be able to update his password only when giving
the previous password. Currently no need to know
the current password when changing it.

Review

  • Code review CR +2
    • Nicole Hummel +2
    • Helmut Hummel +2
    • Frederic Gaus +1
    • Markus Klein +1
  • Verified V +2
    • Nicole Hummel +2
    • Frederic Gaus +1
    • Markus Klein +1

Issues 1

Files 6

Review log 49

Show 24 earlier messages
  1. Susi Moog commented on patch set 1 05/27/13, 17:19

    Fails Does not work with rsaauth/saltedpasswords

    index.php:468

    missing whitespaces // would $GLOBALS['LANG'] work, too?!

    index.php:470

    missing whitespaces

    locallang.xlf:355

    wrong spelling
  2. Stefan Neufeind commented on patch set 2 05/27/13, 17:19

    Georg, please give some feedback. Would be great to get this into 6.0 imho ...
  3. Stefan Neufeind commented on patch set 2 05/27/13, 17:19

    Could somebody look into making it work with saltedpwd?
  4. Stefan Neufeind uploaded patch set 3 05/27/13, 17:19

  5. Stefan Neufeind commented on patch set 3 05/27/13, 17:19

    hand-rebased
  6. Susi Moog commented on patch set 2 05/27/13, 17:19

    Georg, will you update this patch for saltedpwd usage?
  7. Georg Ringer commented on patch set 2 05/27/13, 17:19

    not yet working with saltedpwd
  8. Georg Ringer uploaded patch set 2 05/27/13, 17:19

  9. Georg Ringer commented on patch set 3 05/27/13, 17:19

    Do not submit IMO this just works with nonsalted .....
  10. Mr. Jenkins commented on patch set 3 05/27/13, 17:19

  11. Stefan Neufeind commented on patch set 3 08/26/13, 19:21

    @Georg: Please review to get this working also with salted passwords. Please also take OpenID-logins into account :-)
    6.2
  12. Anja Leichsenring commented on patch set 3 09/13/14, 21:05

    or maybe abandon? Seems no one cares about it anymore
  13. Mathias Schreiber wrote 12/14/14, 16:55

    Topic changed from 35807 to EXT. setup
  14. Mathias Schreiber wrote 12/14/14, 16:55

    Topic changed from EXT. setup to EXT: setup
  15. Frank Nägler commented on patch set 3 12/23/14, 23:12

    @Georg: Can we abandon this patch? Or any activity on this patch?
  16. Stefan Neufeind uploaded patch set 4 12/25/14, 20:36

  17. Stefan Neufeind commented on patch set 4 12/25/14, 20:40

    * split out check-part against authentication-services from AbstractUserAuthentication * check passwordCurrent against services with authUserBE * make sure passwordCurrent is also properly encrypted (rsaauth) * some minor adjustments along the way How we'll handle input of OpenID-credentials or so is open. How can we find a general solution that is extensible? Would somebody with knowledge in that field maybe agree that we can do it in a followup to this one (and please file a followup / take that task)?
  18. Stefan Neufeind commented on patch set 4 12/25/14, 20:41

    @Georg: Could you please reconsider your -2? Works with saltedpasswords now.
  19. Georg Ringer voted on patch set 4 CR 0 12/25/14, 20:53

  20. Helmut Hummel commented on patch set 4 CR -1 12/25/14, 22:06

    While I would love to have this functionality, it seems that it can only be implemented with some more conceptual thoughts and probably a more thorough refactoring of the setup

    AbstractUserAuthentication.php:804

    not sure if it makes sense to make this part public API. at least for this case, it does not make sense (see other comment)

    SetupModuleController.php:243

    this does not make any sense conceptually. This would call services unrelated to password authentication (e.g. openid, ldap).

    SetupModuleController.php:287

    what is this meant for?
  21. Stefan Neufeind commented on patch set 4 12/25/14, 23:58

    I didn't think somebody wanted to followup on this any longer. And the big -2 blocker was missing saltedpassword-support. So I digged into how that might cleanly be possible. Could somebody take it from here again?

    SetupModuleController.php:243 Reply

    Exactly. This was my full intention. The original patch was lacking support for saltedpasswords, which is implemented as a service. And if password-authentication is provided by ldap or whatever that's something I'd like to support with this as well. That's why it now uses the service-chain. I'm not sure yet how we could easily support services that add their own extra fields (one-time-passwords?).

    SetupModuleController.php:287 Reply

    Drop it. It's a left-over from refactoring of the implementation of this change.
  22. Frederic Gaus uploaded patch set 5 12/27/14, 09:32

  23. Frederic Gaus commented on patch set 5 CR +1 V +1 12/27/14, 09:34

    Only a few smaller code improvements.
  24. Frederic Gaus commented on patch set 5 CR -1 V -1 01/03/15, 20:58

    Sorry, I have to revert my vote. In the documentation it says that there does not have to be a valid default object: "Use this to define the rendering for those values of "key" that do not match any of the values of the "array of cObjects". If no default cObject is defined, an empty string will be returned for the default case."
  1. Frederic Gaus commented on patch set 5 CR +1 V +1 01/03/15, 21:00

    Sorry again. Wrong tab. How embarrassing...
  2. Helmut Hummel commented on patch set 5 CR -2 01/03/15, 22:21

    Sorry, but this is not the correct way to go here. To compare the current password the salted password api should be used instead of opening the authentication process which would also call services unrelated to password compare. There should be code in the install tool how to properly compare salted passwords correctly
  3. Frederic Gaus uploaded patch set 6 01/04/15, 00:25

  4. Frederic Gaus commented on patch set 6 01/04/15, 00:28

    Good point! I provided a new patch set. This one uses the saltFactory to validate the password. Please have a look at it and remove the -2 if you agree! Otherwise please comment and I will try to provide updated patch sets soon
  5. Stefan Neufeind commented on patch set 6 01/04/15, 08:38

    Today it can be salted or not, depending if you have installed and activated it etc. But I think that we should not "hardcode" that for salted passwords here at all. What is with LDAP-login or something else? We have the service-API to check login-credentials. Why is using the service-way to look for "authBE" (everybody who provides auth, in correct order, ...) the wrong way?
  6. Helmut Hummel commented on patch set 6 CR -1 01/05/15, 14:34

    looks much better now. The label must not be removed though

    locallang.xlf:309

    why is this removed with this patch? In general, we must not remove labels as it affects older branches as well.
  7. Helmut Hummel commented on patch set 6 01/05/15, 14:37

    @Stefan: > Today it can be salted or not, Wrong! Salted passwords are enforced for backend users since 6.2 > What is with LDAP-login or something else We *cannot* change LDAP passwords from TYPO3. TYPO3 can only change passwords it owns. These are always stored in the database and are always salted. Checking the whole stack of login services would be wrong! It could happen that a service authenticates a user even if a wrong password is given. That is not what we want here!
  8. Frederic Gaus uploaded patch set 7 01/05/15, 15:43

  9. Frederic Gaus commented on patch set 7 CR +1 V +1 01/05/15, 15:45

    New patch without removed labels as Helmut suggested.
  10. Frederic Gaus uploaded patch set 8 03/09/15, 07:40

  11. Frederic Gaus commented on patch set 8 CR +1 V +1 03/09/15, 07:40

    rebased
  12. Helmut Hummel commented on patch set 8 CR +2 03/09/15, 09:13

    Implementation wise this is fine now, thanks! Everything could be nicer and more generic, but it does not add much more mess than present before, so cleanup/ refactoring can be done at a later point.
  13. Nicole Hummel commented on patch set 8 V -1 03/09/15, 09:52

    It seems that the new password isn't set anymore. I'll have a look
  14. Nicole Hummel uploaded patch set 9 03/09/15, 10:04

  15. Nicole Hummel voted on patch set 9 CR +1 V +1 03/09/15, 10:05

  16. Frederic Gaus commented on patch set 9 CR +1 V +1 03/09/15, 10:15

    Ups, didn't checked this correctly :(
  17. Markus Klein commented on patch set 9 CR -1 03/09/15, 13:47

    SetupModuleController.php:91

    int

    SetupModuleController.php:244

    datahandler hook of salted should take care of hashing the password!
  18. Markus Klein commented on patch set 9 03/09/15, 13:47

    will push an update
  19. Markus Klein uploaded patch set 10 03/09/15, 13:52

  20. Markus Klein uploaded patch set 11 03/09/15, 13:55

  21. Markus Klein voted on patch set 11 CR +1 V +1 03/09/15, 13:56

  22. Frederic Gaus voted on patch set 11 CR +1 V +1 03/09/15, 14:18

  23. Nicole Hummel voted on patch set 11 CR +2 V +2 03/09/15, 14:40

  24. Helmut Hummel commented on patch set 11 CR +2 03/09/15, 15:13

    Very nice, thank you! Great to have this in now!
  25. Helmut Hummel merged patch set 11 03/09/15, 15:14