Review TYPO3_4-5 Merged

1030[BUGFIX] Additions to fileDenyPattern give security warning in BE

Steffen Kamper CR +2 V +1 Easy +14 −7 updated 06/03/13, 20:49

Commit message

The check is wrong. Instead of checking if the entry is equal to default entry, it should check if any parts of the default value are removed.

As it's a security warning, this should be stated in the warning, so change the wording.

Review

  • Code review CR +2
    • Andreas Wolf +2
  • Verified V +1
    • Andreas Wolf +1

Files 3

Review log 8

  1. Gerrit wrote 03/08/11, 17:30

    Your change could not be merged due to a path conflict. Please merge (or rebase) the change locally and upload the resolution for review.
  2. Andreas Wolf commented on patch set 1 03/08/11, 17:30

    Verified; Looks good to me, approved Tested and works. Committing this one as it has enough positive votes.
  3. Andreas Wolf uploaded patch set 2 03/08/11, 17:30

  4. Tolleiv Nietsch commented on patch set 1 03/08/11, 17:30

    Looks good to me, but someone else must approve
  5. Björn Pedersen commented on patch set 1 03/08/11, 17:30

    Looks good to me, but someone else must approve Looks Ok for me
  6. Andreas Wolf commented on patch set 2 03/08/11, 17:30

    Verified; Looks good to me, approved Made the patch apply to current trunk. No change in the code whatsoever, so committing this without any additional review by somebody else.
  7. Andreas Wolf commented on patch set 2 03/08/11, 17:30

    Made the patch apply to current trunk. No change in the code whatsoever, so committing this without any additional review by somebody else.
  8. Andreas Wolf merged patch set 2 03/08/11, 17:30