Review main Merged

10308[TASK] Add update-wizard for Media Flexform

Steffen Ritter CR +2 V +2 Normal +109 −1 updated 06/03/13, 20:49

Commit message

While adding the new media stuff the flexform has been altered.
Therefore a update wizard needs to be provided to not lose the
old media elements.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2

Issues 1

Files 3

Review log 9

  1. Steffen Ritter uploaded patch set 2 06/30/12, 14:22

  2. Lorenz Ulrich commented on patch set 2 06/30/12, 14:22

    (2 inline comments) Some nitpicking.
  3. Wouter Wolters commented on patch set 1 06/30/12, 14:22

    I would prefer that you didn't submit this See inline comments

    ext_localconf.php:55

    This is removed for master. See https://review.typo3.org/#/c/10246/

    class.tx_install.php:56

    class.tx_coreupdates_mediaflexform.php:35 Reply

    Done

    class.tx_coreupdates_mediaflexform.php:56

    space

    class.tx_coreupdates_mediaflexform.php:59 Reply

    Done

    class.tx_coreupdates_mediaflexform.php:98

    tabs
  4. Wouter Wolters commented on patch set 2 06/30/12, 14:22

    (2 inline comments)
  5. Mr. Jenkins commented on patch set 3 06/30/12, 14:22

  6. Wouter Wolters commented on patch set 3 06/30/12, 14:22

    Rebased and fixed some minor CGL things
  7. Wouter Wolters uploaded patch set 3 06/30/12, 14:22

  8. Christian Kuhn commented on patch set 3 V 0 06/30/12, 14:22

    by team member; Looks good to me, approved Since this was already merged in 4.7 long ago, I just merge this to master now as well ... This shouldn't happen!
  9. Christian Kuhn merged patch set 3 06/30/12, 14:22