Review main Merged

1031[BUGFIX] Additions to fileDenyPattern give security warning in BE

Steffen Kamper CR +2 V +1 Easy +12 −5 updated 06/03/13, 20:49

Commit message

The check is wrong. Instead of checking if the entry is equal to default entry, it should check if any parts of the default value are removed.

As it's a security warning, this should be stated in the warning, so change the wording.

Review

  • Code review CR +2
    • Andreas Wolf +2
    • Steffen Ritter +1
  • Verified V +1
    • Steffen Ritter +1
    • Andreas Wolf +1

Files 3

Review log 4

  1. Andreas Wolf commented on patch set 1 03/08/11, 17:39

    Verified; Looks good to me, but someone else must approve Works as advertised. Good work! :-)
  2. Andreas Wolf commented on patch set 1 03/08/11, 17:39

    Looks good to me, approved Enough +1s for a commit... Hooray! :-)
  3. Steffen Ritter commented on patch set 1 03/08/11, 17:39

    Verified; Looks good to me, but someone else must approve Looks good to me
  4. Andreas Wolf merged patch set 1 03/08/11, 17:39