Review main Merged

10318[FEATURE] Improve rendering of CE in page module

Georg Ringer CR +2 V +2 Normal +144 −92 updated 06/03/13, 20:49

Commit message

Rendering of content elements in page module can be
improved by making it easier and streamline it. See
details in issue.

Review

  • Code review CR +2
    • Stefan Galinski +2
    • Christian Kuhn +1
    • Felix Kopp +1
    • Philipp Gampe +1
  • Verified V +2
    • Stefan Galinski +2
    • Christian Kuhn +1
    • Felix Kopp +1
    • Philipp Gampe +1

Issues 1

Files 6

Review log 25

  1. Georg Ringer uploaded patch set 2 04/13/12, 10:03

  2. Georg Ringer uploaded patch set 3 04/13/12, 10:03

  3. Georg Ringer uploaded patch set 4 04/13/12, 10:03

  4. Philipp Gampe uploaded patch set 5 04/13/12, 10:03

    missing .

    class.tx_cms_layout.php:1576

    space instead of tab

    class.tx_cms_layout.php:1577

    space instead of tab

    class.tx_cms_layout.php:1579

    both parameters $space and $langMode are not used, please include parameter name in phpdoc: * @param array $row Record array

    class.tx_cms_layout.php:1582

    one more tab

    class.tx_cms_layout.php:1620

    @todo or please remove

    class.tx_cms_layout.php:1620 Reply

    icon + ctype in titel/popup please :)

    main_content.css:153

    padding, margin and display should be in structure in in visual

    module_web_page.css:79

    space after colon
  5. Georg Ringer commented on patch set 6 04/13/12, 10:03

    (5 inline comments)
  6. Susi Moog commented on patch set 7 2 comments 04/13/12, 10:03

    Verified; I would prefer that you didn't submit this Please have a look at the comments. Thx ;)
  7. Georg Ringer uploaded patch set 7 04/13/12, 10:03

  8. Stefan Galinski uploaded patch set 9 04/13/12, 10:03

  9. Stefan Galinski commented on patch set 9 04/13/12, 10:03

    Verified; Looks good to me, but someone else must approve Changes in patchset 9: - incorrectly aligned icons in IE7 - fixed broken option that hides the "new record button" - fixed the nitpicks - added a new language label for the new button to reflect it's new position
  10. Stefan Galinski commented on patch set 9 04/13/12, 10:03

    @Felix: Please open a ticket in the gridelements extension so that Joey is informed.
  11. Stefan Galinski commented on patch set 9 04/13/12, 10:03

    This was intented like you will see if you carefully read the description on forge. ;-)
  12. Christian Kuhn commented on patch set 9 04/13/12, 10:03

    Verified; Looks good to me, but someone else must approve
  13. Georg Ringer uploaded patch set 8 04/13/12, 10:03

  14. Philipp Gampe uploaded patch set 6 04/13/12, 10:03

  15. Philipp Gampe commented on patch set 6 04/13/12, 10:03

    sorry, restored version 4
  16. Philipp Gampe commented on patch set 6 04/13/12, 10:03

    (1 inline comment)
  17. Philipp Gampe commented on patch set 6 6 comments 04/13/12, 10:03

    Verified; I would prefer that you didn't submit this Nice improvement.
  18. Philipp Gampe commented on patch set 8 2 comments 04/13/12, 10:03

    Looks good to me, but someone else must approve Nitpick only if another version is needed.
  19. Philipp Gampe commented on patch set 9 04/13/12, 10:03

    Verified; Looks good to me, but someone else must approve
  20. Felix Kopp commented on patch set 9 04/13/12, 10:03

    Verified; Looks good to me, but someone else must approve
  21. Felix Kopp commented on patch set 9 04/13/12, 10:03

    Breaks GridElements drag and drop (should be solved by Grid?)
  22. Felix Kopp commented on patch set 9 04/13/12, 10:03

    The hover background on up/down buttons is differently from the other header gradient. Please see screenshot on forge
  23. Felix Kopp commented on patch set 9 04/13/12, 10:03

    :) found it. But why?
  24. Stefan Galinski commented on patch set 9 V 0 04/13/12, 10:03

    by team member; Looks good to me, approved
  25. Stefan Galinski merged patch set 9 04/13/12, 10:03