10318[FEATURE] Improve rendering of CE in page module
Commit message
Review
-
Code review CR +2
- Stefan Galinski +2
- Christian Kuhn +1
- Felix Kopp +1
- Philipp Gampe +1
-
Verified V +2
- Stefan Galinski +2
- Christian Kuhn +1
- Felix Kopp +1
- Philipp Gampe +1
Issues 1
Files 6
- t3lib/class.t3lib_recordlist.php+12 −5
- typo3/sysext/cms/layout/class.tx_cms_layout.php11+99 −77
- typo3/sysext/cms/layout/locallang.xlf+3 −0
- typo3/sysext/t3skin/stylesheets/structure/module_web_page.css+19 −10
- typo3/sysext/t3skin/stylesheets/visual/main_content.css2+7 −0
- typo3/sysext/t3skin/stylesheets/visual/module_web_page.css2+4 −0
Review log 25
-
Georg Ringer uploaded patch set 2 04/13/12, 10:03
-
Georg Ringer uploaded patch set 3 04/13/12, 10:03
-
Georg Ringer uploaded patch set 4 04/13/12, 10:03
-
Philipp Gampe uploaded patch set 5 04/13/12, 10:03
missing .class.tx_cms_layout.php:1576space instead of tabclass.tx_cms_layout.php:1577space instead of tabclass.tx_cms_layout.php:1579both parameters $space and $langMode are not used, please include parameter name in phpdoc: * @param array $row Record arrayclass.tx_cms_layout.php:1582one more tabclass.tx_cms_layout.php:1620@todo or please removeclass.tx_cms_layout.php:1620Replyicon + ctype in titel/popup please :)main_content.css:153padding, margin and display should be in structure in in visualmodule_web_page.css:79space after colon -
Georg Ringer commented on patch set 6 04/13/12, 10:03
(5 inline comments) -
Susi Moog commented on patch set 7 2 comments 04/13/12, 10:03
Verified; I would prefer that you didn't submit this Please have a look at the comments. Thx ;) -
Georg Ringer uploaded patch set 7 04/13/12, 10:03
-
Stefan Galinski uploaded patch set 9 04/13/12, 10:03
-
Stefan Galinski commented on patch set 9 04/13/12, 10:03
Verified; Looks good to me, but someone else must approve Changes in patchset 9: - incorrectly aligned icons in IE7 - fixed broken option that hides the "new record button" - fixed the nitpicks - added a new language label for the new button to reflect it's new position -
Stefan Galinski commented on patch set 9 04/13/12, 10:03
@Felix: Please open a ticket in the gridelements extension so that Joey is informed. -
Stefan Galinski commented on patch set 9 04/13/12, 10:03
This was intented like you will see if you carefully read the description on forge. ;-) -
Christian Kuhn commented on patch set 9 04/13/12, 10:03
Verified; Looks good to me, but someone else must approve -
Georg Ringer uploaded patch set 8 04/13/12, 10:03
-
Philipp Gampe uploaded patch set 6 04/13/12, 10:03
-
Philipp Gampe commented on patch set 6 04/13/12, 10:03
sorry, restored version 4 -
Philipp Gampe commented on patch set 6 04/13/12, 10:03
(1 inline comment) -
Philipp Gampe commented on patch set 6 6 comments 04/13/12, 10:03
Verified; I would prefer that you didn't submit this Nice improvement. -
Philipp Gampe commented on patch set 8 2 comments 04/13/12, 10:03
Looks good to me, but someone else must approve Nitpick only if another version is needed. -
Philipp Gampe commented on patch set 9 04/13/12, 10:03
Verified; Looks good to me, but someone else must approve -
Felix Kopp commented on patch set 9 04/13/12, 10:03
Verified; Looks good to me, but someone else must approve -
Felix Kopp commented on patch set 9 04/13/12, 10:03
Breaks GridElements drag and drop (should be solved by Grid?) -
Felix Kopp commented on patch set 9 04/13/12, 10:03
The hover background on up/down buttons is differently from the other header gradient. Please see screenshot on forge -
Felix Kopp commented on patch set 9 04/13/12, 10:03
:) found it. But why? -
Stefan Galinski commented on patch set 9 V 0 04/13/12, 10:03
by team member; Looks good to me, approved -
Stefan Galinski merged patch set 9 04/13/12, 10:03