Review TYPO3_4-5 Merged

1034[BUGFIX] Error 414 - "Request-URI Too Large" when saving file in extension manager (old version)

Steffen Kamper CR +2 V +1 Easy +1 −1 updated 06/03/13, 20:49

Commit message

Due a missing closing " the form has invalid HTML that result in a very long GET request

Review

  • Code review CR +2
    • Steffen Kamper +2
  • Verified V +1
    • Chris topher +1

Files 1

Review log 6

  1. Steffen Kamper commented on patch set 1 03/05/11, 14:28

    Looks good to me, approved It's a nobrainer - should i submit?
  2. Steffen Kamper commented on patch set 1 03/05/11, 14:28

    Christopher - i don't know exactly. There are 2 columns for review and verify (it's testing and reading) In the overview you have those 2 columns too. Anyway thanks for the review.
  3. Chris topher commented on patch set 1 03/05/11, 14:28

    Verified; Looks good to me, but someone else must approve Obviously OK.
  4. Chris topher commented on patch set 1 03/05/11, 14:28

    Steffen, there still are problems with voting for a patch: In this thread you already gave all needed votes for the Code Review. This produced a "checked" sign ("approved") in the overview list. When now I add another "Code Review: +1", the checked sign is gone and it says "Looks good to me, but someone else must approve." That is wrong: The number of votes got even more than needed; there is nothing which still must be approved. I think the checked sign and the comment "approved" should stay in that case. (Or do I misunderstand how that should work?)
  5. Chris topher voted on patch set 1 V 0 03/05/11, 14:28

  6. Steffen Kamper merged patch set 1 03/05/11, 14:28