Review main Merged

1037[FEATURE] pagetree dataprovider should enable node postprocessing

Tolleiv Nietsch CR +2 V +2 Normal +107 −1 updated 06/03/13, 20:49

Commit message

In order to change pagetree node properties the dataprovider should enable
postprocessing of the node-collections. Used e.g. to highlight nodes
when tt_content elements have changed on a page.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Susi Moog +2
  • Verified V +2
    • Susi Moog +2
    • Georg Ringer +1

Issues 1

Files 3

Review log 25

  1. Ernesto Baschny commented on patch set 2 07/09/11, 09:33

    Looks good to me, but someone else must approve Please document the methods of the interface with some more information before committing.

    interface.t3lib_tree_pagetree_interfaces_collectionprocessor.php:38

    I would appreciate if you could add some documentation to these methods, explaining when exactly they are called and giving some information about what can be manipulated here (or not). Same applies to the other three methods below.
  2. Ernesto Baschny commented on patch set 2 07/09/11, 09:33

    @Tolleiv, yes, it is ok :)
  3. Tolleiv Nietsch uploaded patch set 2 07/09/11, 09:33

  4. Tolleiv Nietsch commented on patch set 2 07/09/11, 09:33

    Ernesto is it ok for you to add these hooks also to 4.5 ? I will add the documentation of course.
  5. Tolleiv Nietsch uploaded patch set 3 07/09/11, 09:33

  6. Tolleiv Nietsch commented on patch set 3 07/09/11, 09:33

    (1 inline comment)
  7. Sonja Schubert commented on patch set 2 07/09/11, 09:33

    Verified; Looks good to me, but someone else must approve
  8. Björn Pedersen commented on patch set 2 07/09/11, 09:33

    Looks good to me, but someone else must approve
  9. Björn Pedersen commented on patch set 2 07/09/11, 09:33

    @Simon: Are you sure this patch is the source of your problem? To me it looks like a workspace problem, where CE changes on a page are not propagated to the page tree.
  10. Stefan Neufeind commented on patch set 2 07/09/11, 09:33

    Looks good to me, but someone else must approve Only minor additions needed, looks good. Would be nice to have in.
  11. Stefan Neufeind commented on patch set 3 07/09/11, 09:33

    Looks good to me, but someone else must approve
  12. Susi Moog uploaded patch set 4 07/09/11, 09:33

  13. Susi Moog commented on patch set 4 07/09/11, 09:33

    Verified; Looks good to me, but someone else must approve Only fixed the white space errors.
  14. Stefan Galinski commented on patch set 2 07/09/11, 09:33

    Verified; Looks good to me, but someone else must approve
  15. Georg Ringer commented on patch set 2 07/09/11, 09:33

    Looks good to me, but someone else must approve

    class.t3lib_tree_pagetree_dataprovider.php:81

    is this now the behaviour: i would prefer an additional is_array instead of the type casting
  16. Georg Ringer commented on patch set 3 1 comment 07/09/11, 09:33

    Looks good to me, but someone else must approve
  17. Georg Ringer commented on patch set 3 07/09/11, 09:33

    (1 inline comment)
  18. Georg Ringer commented on patch set 4 07/09/11, 09:33

    Verified; Looks good to me, approved
  19. Steffen Gebert commented on patch set 2 07/09/11, 09:33

    I would prefer that you didn't submit this
    Please use "Resolves: #25255"
  20. Simon Schaufelberger commented on patch set 2 07/09/11, 09:33

    Fails I tested it and for me it does not work. I have changed a content element in workspace. the ce has a green background now but the page in the pagetree still have no green background. The page in the pagetree only becomes green, if i change the page properties of the page.
  21. Simon Schaufelberger commented on patch set 2 07/09/11, 09:33

    I am using: $GLOBALS['TBE_STYLES']['stylesheet2'] = '../fileadmin/templates/plugins/typo3_skin/add_styles.css'; in ext_tables.php containing: #typo3-alt-db-navframe-php .workspace-info { margin: 10px 0 0 10px; border: none; } #typo3-versionSelector { border: 1px solid #FF0000; background-color: #ff9999!important; background-image: url('../icons/gfx/alt_menu_mainitem_bg.gif'); background-repeat: repeat-x; } #typo3-versionSelector td { color: #FFFFFF; } #PageTreeDiv ul.tree li.active, #PageTreeDiv ul.tree ul li.active { background-color: #ffe4e1!important; } #PageTreeDiv ul.tree li.active a, #PageTreeDiv ul.tree ul li.active a { color: #FF0000; } .ver-element, UL.tree UL LI.ver-element {background-color: #ccffcc!important; } .ver-page, UL.tree UL LI.ver-page { background-color: #ff9999; } .ver-branch, UL.tree UL LI.ver-branch { background-color: #ccccff; } .ver-branchpoint, UL.tree UL LI.ver-branchpoint { background-color: #ff9999; } .ver-versions, UL.tree UL LI.ver-versions { background-color: #ffffaa;}
  22. Mr. Jenkins commented on patch set 3 07/09/11, 09:33

  23. Mr. Jenkins commented on patch set 4 07/09/11, 09:33

  24. Susi Moog commented on patch set 4 V 0 07/09/11, 09:33

    by team member; Looks good to me, approved
  25. Susi Moog merged patch set 4 07/09/11, 09:33