Review main Merged

10388[FEATURE] New menu type "Sitemaps of selected pages" in CE "Menu/Sitemap"

Marco Huber CR +2 V +2 Easy +13 −0 updated 06/03/13, 20:49

Commit message

In the content element "Menu/Sitemap" it would be nice to be able to select
the root page for the sitemap, because the current menu type "Sitemap"
always uses the tree root. We could enable this with introducing a new
menu type "Sitemaps of selected pages".

Review

  • Code review CR +2
    • Tolleiv Nietsch +2
    • Markus Klein +1
    • Max Roesch +1
    • Philipp Gampe +1
  • Verified V +2
    • Tolleiv Nietsch +2
    • Markus Klein +1
    • Max Roesch +1
    • Philipp Gampe +1

Issues 1

Files 3

Review log 8

  1. Philipp Gampe commented on patch set 1 05/07/12, 06:32

    Looks good to me, but someone else must approve I will push an updated commit message in a minute.
    Releases: 6.0
  2. Tolleiv Nietsch commented on patch set 2 V 0 05/07/12, 06:32

    by team member; Looks good to me, approved
  3. Markus Klein commented on patch set 2 05/07/12, 06:32

    Verified; Looks good to me, but someone else must approve
  4. Max Roesch commented on patch set 2 05/07/12, 06:32

    Verified; Looks good to me, but someone else must approve
  5. Philipp Gampe commented on patch set 2 05/07/12, 06:32

    Fails; Looks good to me, but someone else must approve For some reason I only get the selected page ?! The TS looks good, but I want to have lunch first.
  6. Philipp Gampe commented on patch set 2 V 0 05/07/12, 06:32

    seemed to be a cache issue
  7. Philipp Gampe uploaded patch set 2 05/07/12, 06:32

  8. Tolleiv Nietsch merged patch set 2 05/07/12, 06:32