10448[BUGFIX] BE ignores l10n_mode for record titles
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
-
Verified V +2
- Stefan Neufeind +2
Files 2
Review log 59
Show 34 earlier messages
-
Tolleiv Nietsch commented on patch set 2 05/27/13, 17:19
I would prefer that you didn't submit this I assume in "!isset(...)" the negation is a mistake? --- How to test easily? -
Markus Klein uploaded patch set 2 05/27/13, 17:19
-
Stefan Neufeind commented on patch set 3 05/27/13, 17:19
Looks good to me, but someone else must approve -
Stefan Neufeind uploaded patch set 4 05/27/13, 17:19
-
Stefan Neufeind commented on patch set 4 05/27/13, 17:19
hand-rebased had 1x verified, 2x review -
Markus Klein uploaded patch set 3 05/27/13, 17:19
-
Markus Klein commented on patch set 3 05/27/13, 17:19
Thanks Tolleiv, I introduced this mistake in Set 2. You can test this by simply setting in ext_tables.php: t3lib_div::loadTCA('tt_content'); $GLOBALS['TCA']['tt_content']['columns']['header']['l10n_mode'] = 'exclude'; $GLOBALS['TCA']['tt_content']['ctrl']['label_alt'] = ''; Then you translate any content element and [No Title] will be shown without the patch. Note: Nobody would do this for tt_content, but it's relevant for extension tables. tt_content is just a nice way to test. -
Stefan Neufeind commented on patch set 5 05/27/13, 17:19
(1 inline comment) -
Markus Klein uploaded patch set 5 05/27/13, 17:19
-
Markus Klein commented on patch set 5 05/27/13, 17:19
Verified; Looks good to me, but someone else must approve Rebased. Had 1x verified and 2x reviewed -
Markus Klein commented on patch set 6 05/27/13, 17:19
Rebased -
Markus Klein uploaded patch set 6 05/27/13, 17:19
-
Markus Klein commented on patch set 6 05/27/13, 17:19
Verified; Looks good to me, but someone else must approve Fixed the comment issue and reapplied votes. -
Markus Klein uploaded patch set 8 05/27/13, 17:19
-
Stefan Galinski commented on patch set 3 05/27/13, 17:19
Verified; Looks good to me, but someone else must approve -
Georg Ringer commented on patch set 1 05/27/13, 17:19
I would prefer that you didn't submit thisclass.t3lib_befunc.php:5dont mess up with kasper ;) -
Mr. Jenkins commented on patch set 3 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3782/ : SUCCESS -
Mr. Jenkins commented on patch set 4 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6850/ : SUCCESS -
Mr. Jenkins commented on patch set 5 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7512/ : SUCCESS -
Mr. Jenkins commented on patch set 6 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7519/ : SUCCESS -
Mr. Jenkins commented on patch set 7 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8545/ : SUCCESS -
Mr. Jenkins commented on patch set 8 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8546/ : SUCCESS -
Markus Klein uploaded patch set 9 06/04/13, 22:35
-
Markus Klein commented on patch set 9 06/04/13, 22:36
Just another rebase -
Stefan Neufeind commented on patch set 9 CR +1 07/06/13, 16:32
maybe only 6.2, 6.1, 6.0BackendUtility.php:836it seems some editor wrapped this around into two lines. Imho we should either shorten this a bit, break it into multiple lines etc. or make sure it at least isn't touched by this patchset imho. I've downloaded the resulting file and it's indeed two lines now. -
Markus Klein updated the commit message in patch set 9 07/06/13, 16:49
-
Mr. Jenkins commented on patch set 10 07/06/13, 16:50
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9490/ : SUCCESS -
Markus Klein rebased onto patch set 10 09/18/13, 10:23
-
Mr. Jenkins commented on patch set 11 09/18/13, 10:24
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10806/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/10808/ : SUCCESS -
Markus Klein commented on patch set 11 09/26/13, 23:33
Reviews please! -
Markus Klein commented on patch set 11 10/10/13, 18:28
Ping -
Markus Klein uploaded patch set 12 12/02/13, 11:47
-
Mr. Jenkins commented on patch set 12 12/02/13, 12:27
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12443/ : SUCCESS -
Markus Klein rebased onto patch set 12 12/29/13, 14:19
-
Mr. Jenkins commented on patch set 13 12/29/13, 14:33
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12719/ : SUCCESS -
Markus Klein commented on patch set 13 CR -1 12/29/13, 15:13
Will push a new version with unit tests -
Markus Klein uploaded patch set 14 12/29/13, 15:46
-
Mr. Jenkins commented on patch set 14 12/29/13, 16:00
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12720/ : SUCCESS -
Markus Klein rebased onto patch set 14 01/23/14, 19:54
-
Mr. Jenkins commented on patch set 15 01/23/14, 20:18
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13188/ : SUCCESS -
Markus Klein uploaded patch set 16 02/04/14, 19:30
-
Georg Ringer voted on patch set 16 CR -2 02/04/14, 19:30
-
Mr. Jenkins commented on patch set 16 02/04/14, 19:44
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13708/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/13707/ : SUCCESS -
Wouter Wolters commented on patch set 16 02/05/14, 22:31
Will give it a try tomorrowBackendUtility.php:1951tab ->space -
Markus Klein uploaded patch set 17 02/05/14, 23:49
-
Mr. Jenkins commented on patch set 17 02/06/14, 00:05
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13746/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/13745/ : SUCCESS -
Markus Klein rebased onto patch set 17 02/24/14, 16:21
-
Mr. Jenkins commented on patch set 18 02/24/14, 16:35
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14277/ : SUCCESS -
Markus Klein updated the commit message in patch set 18 03/13/14, 11:55
-
Mr. Jenkins commented on patch set 19 03/13/14, 12:09
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15040/ : SUCCESS -
Stefan Neufeind voted on patch set 19 CR +1 03/13/14, 12:40
-
Stefan Neufeind commented on patch set 19 04/02/14, 12:28
Would be great to maybe get this beast done somehow ... -
Stefan Neufeind uploaded patch set 20 04/15/14, 00:23
-
Stefan Neufeind commented on patch set 20 V +1 CR +1 04/15/14, 00:24
had to rebase locally because of the unittest-file -
Mr. Jenkins commented on patch set 20 04/15/14, 00:38
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16009/ : SUCCESS -
Stefan Neufeind commented on patch set 20 V +2 CR +2 04/15/14, 16:38
Has gone way too much rounds already imho. I think this is safe to go now. The barrier to get people to review this seems to be a bit high imho. -
Stefan Neufeind merged patch set 21 04/15/14, 16:38
-
Christian Kuhn commented on patch set 21 04/15/14, 17:59
Post -1: Not enough votes! Triggers warnings in functional tests, and the test is not up-to-date (no backup needed, $subject instead of $fixture). This only on reading, did no technical deep analysis. -
Christian Kuhn commented on patch set 21 04/15/14, 19:49
-1 for 6.1 in case, no backport please!