Review TYPO3_4-7 Merged

10475[TASK] Change hardcoded URL to constant

Christian Kuhn CR +2 V +2 Easy +2 −2 updated 06/03/13, 20:49

Commit message

Change hardcoded typo3.org url to the
constant TYPO3_URL_GENERAL in class.typo3logo.php

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Sascha Egerer +1
  • Verified V +2
    • Christian Kuhn +2
    • Sascha Egerer +1

Issues 1

Files 1

Review log 3

  1. Sascha Egerer commented on patch set 1 04/15/12, 15:15

    Verified; Looks good to me, but someone else must approve
  2. Christian Kuhn commented on patch set 1 V 0 04/15/12, 15:15

    by team member; Looks good to me, approved Identical to master. @Steffen: This one was already merged in 4.5, 4.6 and master. Please decide if you want it in 4.7 RC
  3. Steffen Ritter merged patch set 1 04/15/12, 15:15