10489[BUGFIX] Double encoded HTML entities in originalLanguage
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 2
Review log 27
Show 2 earlier messages
-
Stefan Neufeind commented on patch set 3 05/27/13, 17:19
(2 inline comments)class.t3lib_diff.php:100add a space after commasclass.t3lib_diff.php:106htmlspecialchars() needs 'UTF-8'-parameter as well afaik Although only "safe" characters seem to be replaced, it would be consistent to have UTF-8 used in the parameters. And php-documentation says that in case of incorrect characters the returned string would be empty. So better be safe here. -
Stefan Neufeind commented on patch set 3 05/27/13, 17:19
Looks good to me, but someone else must approve -
Sascha Egerer commented on patch set 4 05/27/13, 17:19
Rebased -
Sascha Egerer commented on patch set 5 05/27/13, 17:19
Verified; Looks good to me, but someone else must approve -
Dmitry Dulepov commented on patch set 4 05/27/13, 17:19
Fails; I would prefer that you didn't submit this This will fail under certain PHP versions. Please, see bug #39287. -
Dmitry Dulepov commented on patch set 4 05/27/13, 17:19
No score; No score Sorry, looked to the wrong place. Removing -1. -
Stefan Neufeind commented on patch set 4 05/27/13, 17:19
Looks good to me, but someone else must approve hand-rebased and added UTF-8-parameter for htmlspecialchars as well to be clean (needed for pre-5.4, to be safe). essential part is the entity-decode here had 1x verify, 2x review -
Stefan Neufeind uploaded patch set 4 05/27/13, 17:19
-
Stefan Neufeind commented on patch set 5 05/27/13, 17:19
Looks good to me, but someone else must approve -
Stefan Neufeind commented on patch set 5 V 0 05/27/13, 17:19
How to test: * Create record in default-language, enter something in the RTE-field which contains a quote-character * Create a translation of that record and watch the preview Result without patch: " will be shown because it is double-encoded. Expected result: A healthy TYPO3 :-) -
Benni Mack commented on patch set 5 05/27/13, 17:19
could not reproduce... -
Philipp Gampe commented on patch set 3 05/27/13, 17:19
Verified; Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 4 05/27/13, 17:19
Verified; Looks good to me, but someone else must approve reapplying vote -
Philipp Gampe commented on patch set 5 05/27/13, 17:19
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 4 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6861/ : SUCCESS -
Mr. Jenkins commented on patch set 5 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8187/ : SUCCESS -
Stefan Neufeind commented on patch set 5 08/05/13, 20:36
and 6.2, 6.1 I guess? Think I tested that on master "back then" (probably 6.1 but more likely already 6.2) -
Alexander Opitz commented on patch set 5 08/22/13, 09:43
I don't think that this is the right way, if you now want to write a text to explain HTML Tags it gets converted to real sign. Also it doesn't fix the problem for other output systems which aren't xml/html, so the problem is more, why are the things written encoded before they come to output in preview?Reply
4.7 gets only security updates. 4.6 gets no updates any more. -
Stefan Neufeind commented on patch set 5 11/09/13, 16:35
Alex, could you maybe hit the -1 break on this one then? And could somebody maybe have a closed look into this? -
Alexander Opitz voted on patch set 5 CR -1 11/10/13, 14:18
-
Benni Mack commented on patch set 5 12/08/14, 07:09
Could you guys elaborate better on this issue? Otherwise I will abandon this patch in a week. This patch seems to bring more side effects than actually solves them. Additionally, this should go through a unified function. -
Mathias Schreiber wrote 12/14/14, 16:32
Topic changed from 33619 to Formengine -
Mathias Schreiber updated the commit message in patch set 6 12/14/14, 16:38
-
Alexander Opitz commented on patch set 6 CR -1 12/14/14, 17:27
See Patch Set 5 -
Benni Mack abandoned the change 01/08/15, 20:20
No news from anyone, so I will kick that one for now.