10494[BUGFIX] Prevent encoding of HTML entities in backend previews
Commit message
Review
-
Code review CR +2
- Oliver Hader +2
- Stefan Neufeind +1
- Markus Klein +1
- Helmut Hummel +1
-
Verified V +2
- Oliver Hader +2
- Stefan Neufeind +1
- Markus Klein +1
- Helmut Hummel +1
Files 2
Review log 44
Show 19 earlier messages
-
Stefan Neufeind commented on patch set 1 03/12/13, 15:50
Looks good to me, but someone else must approve -
Markus Klein commented on patch set 1 03/12/13, 15:50
Verified; Looks good to me, but someone else must approveclass.tx_cms_layout.php:1752Pay attention in backports that UTF-8 here is only valid for master! -
Dmitry Dulepov commented on patch set 2 03/12/13, 15:50
Looks good to me, but someone else must approve -
Stefan Neufeind commented on patch set 2 03/12/13, 15:50
Looks good to me, but someone else must approve -
Stefan Neufeind commented on patch set 3 03/12/13, 15:50
(1 inline comment) can't / won't vote since I rebased it :-) But would be great to hear from others. -
Stefan Neufeind uploaded patch set 3 03/12/13, 15:50
-
Stefan Neufeind commented on patch set 3 03/12/13, 15:50
(1 inline comment) hand-rebased had 2x verified, 4x review -
Markus Klein uploaded patch set 2 03/12/13, 15:50
-
Markus Klein commented on patch set 2 1 comment 03/12/13, 15:50
Verified; Looks good to me, but someone else must approve -
Markus Klein commented on patch set 3 03/12/13, 15:50
Verified; Looks good to me, but someone else must approve Reapplying vote -
Sascha Egerer commented on patch set 4 03/12/13, 15:50
ping -
Stefan Neufeind commented on patch set 4 03/12/13, 15:50
Would be really great to get this long-standing topic done (reviewed by core-devs) and resolved ... -
Stefan Neufeind commented on patch set 4 03/12/13, 15:50
Looks good to me, but someone else must approve -
Markus Klein uploaded patch set 4 03/12/13, 15:50
-
Markus Klein commented on patch set 4 03/12/13, 15:50
(1 inline comment) -
Markus Klein commented on patch set 4 1 comment 03/12/13, 15:50
Verified; Looks good to me, but someone else must approve -
Helmut Hummel commented on patch set 1 03/12/13, 15:50
Should be easy to add unit tests for this one. Please do so. Thanks. -
Helmut Hummel commented on patch set 4 2 comments 03/12/13, 15:50
I would prefer that you didn't submit this I would oppose backporting this change. Other than that, a short google search https://www.google.de/search?q=html_entity_decode+security does not reveal any critical stuff (for current PHP versions), but it does not make me fee confident that we should use this method at all. Instead I would rather check, if supplying the fourth parameter to htmlspecialchars would do a better job for our usecase. This would also mean that a backport is technically impossible as this only works since PHP 5.3 -
Helmut Hummel uploaded patch set 5 03/12/13, 15:50
-
Helmut Hummel uploaded patch set 6 03/12/13, 15:50
-
Helmut Hummel commented on patch set 6 03/12/13, 15:50
Verified; Looks good to me, but someone else must approve I'm totally fine if it goes in like that, but only in master for now. -
Stefan Neufeind commented on patch set 7 03/12/13, 15:50
Verified; Looks good to me, but someone else must approve -
Markus Klein commented on patch set 7 03/12/13, 15:50
Verified; Looks good to me, but someone else must approve -
Oliver Hader commented on patch set 7 03/12/13, 15:50
Looks good to me, but someone else must approve -
Oliver Hader commented on patch set 7 03/12/13, 15:50
Looks good to me, approved -
Helmut Hummel uploaded patch set 7 03/12/13, 15:50
-
Helmut Hummel commented on patch set 7 03/12/13, 15:50
Verified; Looks good to me, but someone else must approve -
Georg Ringer commented on patch set 1 03/12/13, 15:50
(1 inline comment)PageLayoutView.php:1613Replywe don'T need to backport*everything*!class.tx_cms_layout.php:1752ReplyIMO this needs to be nl2br(htmlspecialchars(trim(html_entity_decode($this->wordWrapper($input),ENT_COMPAT | ENT_,'UTF-8')))); as utf-8 is not always default and this would lead to strange chars out of -
Georg Ringer commented on patch set 1 03/12/13, 15:50
will add the tests -
Georg Ringer commented on patch set 4 1 comment 03/12/13, 15:50
Verified; Looks good to me, but someone else must approve -
Reinhard Führicht commented on patch set 4 03/12/13, 15:50
Verified; Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 1 03/12/13, 15:50
Verified; Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 2 03/12/13, 15:50
Verified; Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 4 03/12/13, 15:50
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 2 03/12/13, 15:50
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3992/ : SUCCESS -
Mr. Jenkins commented on patch set 3 03/12/13, 15:50
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6847/ : SUCCESS -
Mr. Jenkins commented on patch set 4 03/12/13, 15:50
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7095/ : SUCCESS -
Mr. Jenkins commented on patch set 5 03/12/13, 15:50
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7679/ : SUCCESS -
Mr. Jenkins commented on patch set 6 03/12/13, 15:50
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7680/ : SUCCESS -
Mr. Jenkins commented on patch set 7 03/12/13, 15:50
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7681/ : SUCCESS -
Wouter Wolters commented on patch set 4 03/12/13, 15:50
please merge -
Wouter Wolters commented on patch set 4 03/12/13, 15:50
Looks good to me, but someone else must approve -
Oliver Hader commented on patch set 7 V 0 03/12/13, 15:50
by team member -
Oliver Hader merged patch set 8 03/12/13, 15:50