Review TYPO3_4-6 Merged

10559[BUGFIX] Ensure $output is used as string

Peter Niederlag CR +2 V +2 Easy +6 −9 updated 06/03/13, 20:49

Commit message

Problem was introduced by new API t3lib_befunc::helpTextArray()
which changed ::helpText()

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Oliver Klee +1
    • Wouter Wolters +1
    • Mattias Nilsson +1
  • Verified V +2
    • Christian Kuhn +2
    • Mattias Nilsson +1

Files 1

Review log 7

  1. Markus Klein uploaded patch set 2 06/28/12, 19:44

  2. Oliver Klee commented on patch set 2 06/28/12, 19:44

    Looks good to me, but someone else must approve
  3. Georg Ringer commented on patch set 1 06/28/12, 19:44

    I would prefer that you didn't submit this please push to master first and only to other branches if master is done
    Releases: ??

    class.t3lib_befunc.php:2402

    use !empty()
  4. Mattias Nilsson commented on patch set 2 06/28/12, 19:44

    Verified; Looks good to me, but someone else must approve
  5. Wouter Wolters commented on patch set 2 06/28/12, 19:44

    Looks good to me, but someone else must approve
  6. Christian Kuhn commented on patch set 2 V 0 06/28/12, 19:44

    by team member; Looks good to me, approved
  7. Christian Kuhn merged patch set 2 06/28/12, 19:44