Review main Merged

10577[BUGFIX] Ensure $output is used as string

Peter Niederlag CR +2 V +2 Easy +6 −9 updated 06/03/13, 20:49

Commit message

Problem was introduced by new API t3lib_befunc::helpTextArray()
which changed ::helpText()

Review

  • Code review CR +2
    • Susi Moog +2
    • Philipp Gampe +1
  • Verified V +2
    • Susi Moog +2
    • Philipp Gampe +1

Files 1

Review log 9

  1. Peter Niederlag uploaded patch set 2 04/21/12, 10:10

  2. Philipp Gampe commented on patch set 2 04/21/12, 10:10

    (3 inline comments) I will test and push a new version
    Cap
    Cap here too.

    class.t3lib_befunc.php:2435

    Start with cap: // Wrap ...
  3. Philipp Gampe uploaded patch set 3 04/21/12, 10:10

  4. Philipp Gampe commented on patch set 3 04/21/12, 10:10

    Verified; Looks good to me, but someone else must approve Not tested with PHP 5.4. But with PHP 5.3 is works just fine.
  5. Mr. Jenkins commented on patch set 1 04/21/12, 10:10

  6. Mr. Jenkins commented on patch set 2 04/21/12, 10:10

  7. Mr. Jenkins commented on patch set 3 04/21/12, 10:10

  8. Susi Moog commented on patch set 3 V 0 04/21/12, 10:10

    by team member; Looks good to me, approved Tested with PHP 5.4, warnings are gone now.
  9. Susi Moog merged patch set 3 04/21/12, 10:10