Review main Merged

10628[BUGFIX] Add rootline workspace overlay for backend_layouts.

Timo Webler CR +2 V +2 Easy +1 −1 updated 06/03/13, 20:49

Commit message

When fetching the rootline inside a workspace
make sure to fetch the correct overlay.

Review

  • Code review CR +2
    • Tolleiv Nietsch +2
    • Georg Ringer +1
    • Oliver Hader +1
    • Philipp Gampe +1
  • Verified V +2
    • Tolleiv Nietsch +2
    • Georg Ringer +1

Files 1

Review log 12

  1. Georg Ringer commented on patch set 1 04/21/12, 09:39

    (1 inline comment)
    6.0 is missing which is master
  2. Tolleiv Nietsch commented on patch set 2 V 0 04/21/12, 09:39

    by team member; Looks good to me, approved
  3. Oliver Hader commented on patch set 2 04/21/12, 09:39

    @Timo: Removed your own vote...
  4. Oliver Hader commented on patch set 2 04/21/12, 09:39

    Looks good to me, but someone else must approve
  5. Georg Ringer commented on patch set 2 04/21/12, 09:39

    Looks good to me, but someone else must approve
  6. Georg Ringer voted on patch set 2 V 0 04/21/12, 09:39

  7. Philipp Gampe commented on patch set 2 04/21/12, 09:39

    Looks good to me, but someone else must approve @Timo, please do not vote for your own patch
  8. Timo Webler commented on patch set 2 04/21/12, 09:39

    Verified; Looks good to me, but someone else must approve
  9. Timo Webler uploaded patch set 2 04/21/12, 09:39

  10. Mr. Jenkins commented on patch set 1 04/21/12, 09:39

  11. Mr. Jenkins commented on patch set 2 04/21/12, 09:39

  12. Tolleiv Nietsch merged patch set 2 04/21/12, 09:39