Review TYPO3_4-5 Merged

10629[BUGFIX] Add rootline workspace overlay for backend_layouts.

Timo Webler CR +2 V +2 Easy +1 −1 updated 06/03/13, 20:49

Commit message

When fetching the rootline inside a workspace
make sure to fetch the correct overlay.

Review

  • Code review CR +2
    • Ernesto Baschny +2
    • Stefan Neufeind +1
    • Philipp Gampe +1
  • Verified V +2
    • Ernesto Baschny +2

Files 1

Review log 7

  1. Stefan Neufeind commented on patch set 1 07/12/12, 07:10

    Looks good to me, but someone else must approve @Philipp: merged in master meanwhile
  2. Philipp Gampe commented on patch set 1 07/12/12, 07:10

    I would prefer that you didn't submit this not yet merged in master, please wait for master review before backporting to older branches, please do not vote for your own patch
  3. Philipp Gampe commented on patch set 1 07/12/12, 07:10

    Looks good to me, but someone else must approve
  4. Timo Webler commented on patch set 1 07/12/12, 07:10

    Verified; Looks good to me, but someone else must approve
  5. Timo Webler commented on patch set 1 07/12/12, 07:10

    No score; No score
  6. Ernesto Baschny commented on patch set 1 V 0 07/12/12, 07:10

    by team member; Looks good to me, approved
  7. Ernesto Baschny merged patch set 1 07/12/12, 07:10