Review main Merged

10689[BUGFIX] Correct Path Calculation in Cardlayout

Kay Strobach CR +2 V +2 Easy +3 −1 updated 06/03/13, 20:49

Commit message

Fixes absolute path calculation bug and introduces the correct
relative calculation similar to jsFiles.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Stefan Neufeind +1
    • Tolleiv Nietsch +1
  • Verified V +2
    • Christian Kuhn +2
    • Tolleiv Nietsch +1

Files 1

Review log 17

  1. Tolleiv Nietsch commented on patch set 1 06/18/12, 20:51

    How to test?
  2. Tolleiv Nietsch uploaded patch set 2 06/18/12, 20:51

  3. Tolleiv Nietsch commented on patch set 2 06/18/12, 20:51

    Verified; Looks good to me, but someone else must approve Using "t3lib_div::getFileAbsFileName" imho doesn't make sense.
  4. Stefan Neufeind commented on patch set 2 06/18/12, 20:51

    Looks good to me, but someone else must approve
  5. Christian Kuhn commented on patch set 2 06/18/12, 20:51

    Will take care within next 2 days.
  6. Christian Kuhn commented on patch set 2 06/18/12, 20:51

    I would prefer that you didn't submit this I would prefer if the complete code below the makeInstance() call at the end of the file could be transferred to a method within the backend class. As far as I can see there is no good reason to have it not encapsulated in class scope. If this is done, the class path calculation could be easily unit tested and we have no more discussion if this change here is correct or not.
  7. Christian Kuhn commented on patch set 2 06/18/12, 20:51

    still on my list ...
  8. Steffen Ritter commented on patch set 2 06/18/12, 20:51

    looks very "magick" shouldnt be a "resolve backpath" be in there instead of '../' hardcode?
  9. Kay Strobach commented on patch set 1 06/18/12, 20:51

    hi tolleiv, see here for documentation and an extension, which causes the error ;) http://forge.typo3.org/issues/36308#note-4 regards Kay
  10. Kay Strobach commented on patch set 2 06/18/12, 20:51

    maybe typo3/ can be stripped before, but it's not about classic modules and it works very fine ... i appreciate a different idea of solving it. See the wiki for an example: http://wiki.typo3.org/wiki/index.php?title=Extension_Development,_native_ExtJS_Modules
  11. Kay Strobach commented on patch set 2 06/18/12, 20:51

    we need to resolve path's like EXT:extName/... correctly here!
  12. Kay Strobach commented on patch set 2 06/18/12, 20:51

    mhmm correct
  13. Kay Strobach commented on patch set 2 06/18/12, 20:51

    what about a compromis? - we add this commit this for 4.7 and 6.0 and add a task to refactor the code for 6.0?
  14. Mr. Jenkins commented on patch set 1 06/18/12, 20:51

  15. Mr. Jenkins commented on patch set 2 06/18/12, 20:51

  16. Christian Kuhn commented on patch set 2 V 0 06/18/12, 20:51

    by team member; Looks good to me, approved Ok Kay - sorry for the long delay - I'm fine with your patch. Reviewed, tested, created issue #38158, I hope this will be done. Merged.
  17. Christian Kuhn merged patch set 2 06/18/12, 20:51