Review main Merged

10942[BUGFIX] Update sys_refindex to reflect typolink to file in RTE content

Stanislas Rolland CR +2 V +2 Normal +76 −47 updated 06/03/13, 20:49

Commit message

Problem: sys_refindex should be updated when a link to a file is
inserted in or removed from RTE content.
Solution: Add missing softrefs.

Review

  • Code review CR +2
    • Benni Mack +2
    • Mattias Nilsson +1
    • Steffen Ritter +1
    • Helmut Hummel +1
  • Verified V +2
    • Benni Mack +2

Issues 1

Files 1

Review log 18

  1. Stanislas Rolland uploaded patch set 2 03/22/13, 16:55

  2. Stanislas Rolland uploaded patch set 3 03/22/13, 16:55

  3. Benni Mack uploaded patch set 4 03/22/13, 16:55

  4. Benni Mack uploaded patch set 5 03/22/13, 16:55

  5. Stanislas Rolland commented on patch set 6 03/22/13, 16:55

    Not sure about this change. Should we update sys_refindex or sys_file_reference? The file list tooltip (in the Ref. column) shows the references from sys_refindex, but then links to ElementInformationController which shows a different set of references based on sys_file_reference. Something is wrong here. Why should we have two different reference indexes when it comes to files?
  6. Stefan Neufeind commented on patch set 6 03/22/13, 16:55

    (2 inline comments)

    SoftReferenceIndex.php:584

    just to make sure: it's $link_param here and not $linkHandlerValue possibly? identifier still needs to carry the file: prefix?

    SoftReferenceIndex.php:600

    comment on separate line
  7. Benni Mack uploaded patch set 6 03/22/13, 16:55

  8. Benni Mack commented on patch set 6 V 0 03/22/13, 16:55

    by team member; Looks good to me, approved Tested it, and works as expected. However, just to be clear: sys_file_reference is not for tracking references to softrefparser links, but to other DB tables with additional metadata.
  9. Helmut Hummel commented on patch set 6 03/22/13, 16:55

    Looks good to me, but someone else must approve change indeed look obvious I will add unit tests later this evening
  10. Steffen Ritter commented on patch set 6 03/22/13, 16:55

    Looks good to me, but someone else must approve well, softrefparser is crazy bitch - but looks good.
  11. Mattias Nilsson commented on patch set 6 03/22/13, 16:55

    Looks good to me, but someone else must approve
  12. Mr. Jenkins commented on patch set 1 03/22/13, 16:55

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/3887/ : FAILURE
  13. Mr. Jenkins commented on patch set 2 03/22/13, 16:55

  14. Mr. Jenkins commented on patch set 3 03/22/13, 16:55

  15. Mr. Jenkins commented on patch set 4 03/22/13, 16:55

  16. Mr. Jenkins commented on patch set 5 03/22/13, 16:55

  17. Mr. Jenkins commented on patch set 6 03/22/13, 16:55

  18. Benni Mack merged patch set 7 03/22/13, 16:55