1096[FEATURE] add .gitignore for common file exclusions
Commit message
Review
-
Code review CR +2
- Andreas Wolf +2
- Steffen Ritter +1
-
Verified V +1
- Steffen Ritter +1
- Andreas Wolf +1
Files 1
Review log 8
-
Peter Niederlag uploaded patch set 2 03/08/11, 19:24
-
Peter Niederlag commented on patch set 2 03/08/11, 19:24
@andreas: I'd like not to add .orig and .rej as then you can easily see seem and use 'git clean' for cleanup @tolleiv: why should we ignore .gitignore? if you want to adapt/change exlude patterns use .git/info/exclude -
Andreas Wolf commented on patch set 1 03/08/11, 19:24
Verified; I would prefer that you didn't submit this.gitignore:8IMHO you should add these: *~ (temporary files left by e.g. vim) .idea (PHPstorm project) *.orig *.bak *.rej *.swp -
Andreas Wolf commented on patch set 2 03/08/11, 19:24
Looks good to me, approved As we now have two +1s, this is ready for committing :-) -
Andreas Wolf commented on patch set 2 03/08/11, 19:24
Verified; Looks good to me, but someone else must approve Ok, didn't know "git clean" until now... In this case the change is fine with me. -
Tolleiv Nietsch commented on patch set 1 03/08/11, 19:24
Could you add ".idea" (PHPStorm) and ".gitignore" itself ? -
Steffen Ritter commented on patch set 2 03/08/11, 19:24
Verified; Looks good to me, but someone else must approve definitely like this :) -
Andreas Wolf merged patch set 2 03/08/11, 19:24