Review main Merged

10972[FEATURE] Element browser: get default upload folder from $BE_USER

Stanislas Rolland CR +2 V +2 Normal +56 −12 updated 06/03/13, 20:49

Commit message

When no folder is selected, use $BE_USER->getDefaultUploadFolder().

Review

  • Code review CR +2
    • Steffen Ritter +2
    • Benni Mack +1
  • Verified V +2
    • Steffen Ritter +2
    • Benni Mack +1

Issues 1

Files 1

Review log 9

  1. Stefan Neufeind commented on patch set 1 1 comment 10/10/12, 07:34

    Looks good to me, but someone else must approve Can't really judge / test the functionality. But seems to make some sense by reading. Didn't see problematic areas.
  2. Stefan Neufeind commented on patch set 2 10/10/12, 07:34

    (2 inline comments)
  3. Benni Mack commented on patch set 2 10/10/12, 07:34

    Verified; Looks good to me, but someone else must approve the change now applies again and works just perfectly fine for my env.
  4. Benni Mack uploaded patch set 2 10/10/12, 07:34

  5. Steffen Ritter commented on patch set 2 V 0 10/10/12, 07:34

    by team member; Looks good to me, approved
  6. Philipp Gampe commented on patch set 1 10/10/12, 07:34

    (1 inline comment)

    class.browse_links.php:1292

    comments should start upper case
  7. Mr. Jenkins commented on patch set 1 10/10/12, 07:34

  8. Mr. Jenkins commented on patch set 2 10/10/12, 07:34

  9. Steffen Ritter merged patch set 2 10/10/12, 07:34