Review main Merged

11028[TASK] Clean up phpDoc comments in t3lib_befunc

Wouter Wolters CR +2 V +2 Hard +501 −484 updated 06/03/13, 20:49

Commit message

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Tolleiv Nietsch +1
    • Philipp Gampe +1
  • Verified V +2
    • Christian Kuhn +2
    • Tolleiv Nietsch +1
    • Philipp Gampe +1

Issues 1

Files 1

Review log 10

  1. Tolleiv Nietsch commented on patch set 1 05/07/12, 17:20

    Do not submit The patch also touches (deprecated) methods: implodeTSParams updatePagesTSconfig compilePreviewKeyword isPidInVersionizedBranch. Would you please handle them in a separate RFC?
  2. Mr. Jenkins commented on patch set 1 05/07/12, 17:20

  3. Tolleiv Nietsch commented on patch set 2 05/07/12, 17:20

    Verified; Looks good to me, but someone else must approve Better :) ---- tested with another "php -l" syntax check - to make sure nothing broke by accident.
  4. Philipp Gampe commented on patch set 2 05/07/12, 17:20

    Looks good to me, but someone else must approve

    class.t3lib_befunc.php:915

    comment lines should not be longer than 80 chars
  5. Philipp Gampe voted on patch set 2 V 0 05/07/12, 17:20

  6. Mr. Jenkins commented on patch set 2 05/07/12, 17:20

  7. Wouter Wolters commented on patch set 2 05/07/12, 17:20

    For the deprecated stuff I created a Forge-issue: http://forge.typo3.org/issues/36887
  8. Wouter Wolters uploaded patch set 2 05/07/12, 17:20

  9. Christian Kuhn commented on patch set 2 V 0 05/07/12, 17:20

    by team member; Looks good to me, approved
  10. Christian Kuhn merged patch set 2 05/07/12, 17:20