Review main Merged

11068[TASK] Refactor t3lib_mail_Mailer and add unit tests

Helmut Hummel CR +2 V +2 Normal +162 −14 updated 06/03/13, 20:49

Commit message

This change also cleans up some comments and the existing unit test.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Tolleiv Nietsch +1
  • Verified V +2
    • Helmut Hummel +2
    • Tolleiv Nietsch +1

Issues 1

Files 4

Review log 12

  1. Markus Klein commented on patch set 1 05/08/12, 17:54

    (1 inline comment)

    class.t3lib_mail_mailerTest.php:88

    small typo: smtp
  2. Tolleiv Nietsch uploaded patch set 3 05/08/12, 17:54

  3. Tolleiv Nietsch commented on patch set 3 05/08/12, 17:54

    Verified; Looks good to me, but someone else must approve Recent patchset just changed the typo (mentioned by Georg)
  4. Markus Klein commented on patch set 2 05/08/12, 17:54

    Looks good to me, but someone else must approve
  5. Markus Klein commented on patch set 2 V 0 05/08/12, 17:54

    Tests are working.
  6. Markus Klein uploaded patch set 2 05/08/12, 17:54

  7. Georg Ringer commented on patch set 2 05/08/12, 17:54

    Verified; Looks good to me, but someone else must approve

    class.t3lib_mail_mailerTest.php:112

    this should be transport with 'n'
  8. Mr. Jenkins commented on patch set 1 05/08/12, 17:54

  9. Mr. Jenkins commented on patch set 2 05/08/12, 17:54

  10. Mr. Jenkins commented on patch set 3 05/08/12, 17:54

  11. Helmut Hummel commented on patch set 3 V 0 05/08/12, 17:54

    by team member; Looks good to me, approved Thanks for the reviews!
  12. Helmut Hummel merged patch set 3 05/08/12, 17:54