11068[TASK] Refactor t3lib_mail_Mailer and add unit tests
Commit message
Review
-
Code review CR +2
- Helmut Hummel +2
- Tolleiv Nietsch +1
-
Verified V +2
- Helmut Hummel +2
- Tolleiv Nietsch +1
Issues 1
Files 4
Review log 12
-
Markus Klein commented on patch set 1 05/08/12, 17:54
(1 inline comment)class.t3lib_mail_mailerTest.php:88small typo: smtp -
Tolleiv Nietsch uploaded patch set 3 05/08/12, 17:54
-
Tolleiv Nietsch commented on patch set 3 05/08/12, 17:54
Verified; Looks good to me, but someone else must approve Recent patchset just changed the typo (mentioned by Georg) -
Markus Klein commented on patch set 2 05/08/12, 17:54
Looks good to me, but someone else must approve -
Markus Klein commented on patch set 2 V 0 05/08/12, 17:54
Tests are working. -
Markus Klein uploaded patch set 2 05/08/12, 17:54
-
Georg Ringer commented on patch set 2 05/08/12, 17:54
Verified; Looks good to me, but someone else must approveclass.t3lib_mail_mailerTest.php:112this should be transport with 'n' -
Mr. Jenkins commented on patch set 1 05/08/12, 17:54
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3984/ : SUCCESS -
Mr. Jenkins commented on patch set 2 05/08/12, 17:54
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3985/ : SUCCESS -
Mr. Jenkins commented on patch set 3 05/08/12, 17:54
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3990/ : SUCCESS -
Helmut Hummel commented on patch set 3 V 0 05/08/12, 17:54
by team member; Looks good to me, approved Thanks for the reviews! -
Helmut Hummel merged patch set 3 05/08/12, 17:54