11092[BUGFIX] getRecordLocalization() must respect transForeignTable
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Oliver Klee +1
- Markus Klein +1
- Anja Leichsenring +1
-
Verified V +2
- Christian Kuhn +2
- Markus Klein +1
- Anja Leichsenring +1
Issues 1
Files 1
Review log 32
Show 7 earlier messages
-
Martin Tepper uploaded patch set 2 05/27/13, 17:19
-
Stefan Neufeind commented on patch set 2 05/27/13, 17:19
Looks good to me, but someone else must approve seems to make sense by reading.commit-msg should not contain changes like this which you made between revision 1 and 2 or so, just the round-up of things changed by the patchset -
Mr. Jenkins commented on patch set 1 05/27/13, 17:19
No score; No score Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3998/ : SUCCESS -
Mr. Jenkins commented on patch set 1 05/27/13, 17:19
It seems your change set contains whitespaces chars in indentions which should be removed few days before. Could you rebase your local repo to the current master and push it again? -
Mr. Jenkins commented on patch set 1 05/27/13, 17:19
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/3997/ : FAILURE -
Mr. Jenkins commented on patch set 2 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4009/ : SUCCESS -
Stefan Neufeind commented on patch set 3 05/27/13, 17:19
Looks good to me, but someone else must approve Small patch, easy catch? :-)
-
Johannes Feustel commented on patch set 3 05/27/13, 17:19
Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 3 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5299/ : SUCCESS -
Wouter Wolters commented on patch set 3 05/27/13, 17:19
Looks good to me, but someone else must approve Fixed commit message -
Wouter Wolters uploaded patch set 3 05/27/13, 17:19
-
Wouter Wolters uploaded patch set 4 06/29/13, 18:22
-
Mr. Jenkins commented on patch set 4 06/29/13, 18:22
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9262/ : SUCCESS -
Wouter Wolters voted on patch set 4 CR +1 07/16/13, 19:03
-
Dmitry Dulepov voted on patch set 4 CR +1 07/31/13, 12:48
-
Mathias Schreiber wrote 12/14/14, 16:14
Topic changed from 36971 to Backend API -
Anja Leichsenring commented on patch set 4 CR -1 12/21/14, 19:30
I consider this a really sparsely used case, where translations are stored in a seperate table. After this is a non intrusive change, I recommend to merge it anyway, but after the applying rules we need a documentation file in sysext:core/Documentation/Changelog/master. Would you mind to add it? You find examples there. -
Anja Leichsenring updated the commit message in patch set 5 12/21/14, 19:30
-
Anja Leichsenring voted on patch set 5 CR -1 12/21/14, 19:30
-
Anja Leichsenring commented on patch set 5 12/21/14, 19:30
-1 for the missing documentation file, see my comment on patchset 4. -
Georg Ringer commented on patch set 5 CR +1 V +1 12/21/14, 21:27
IMO this is no feature but a bugfix. what you think anja? -
Anja Leichsenring updated the commit message in patch set 6 01/18/15, 12:06
-
Anja Leichsenring voted on patch set 6 CR +1 V +1 01/18/15, 12:06
-
Oliver Klee updated the commit message in patch set 7 01/18/15, 12:07
-
Oliver Klee voted on patch set 7 CR +1 01/18/15, 12:07
-
Anja Leichsenring voted on patch set 7 CR +1 V +1 01/18/15, 12:47
-
Markus Klein commented on patch set 7 CR +1 V +1 01/18/15, 13:16
candiate for 6.2 as well? -
Stefan Neufeind commented on patch set 7 01/18/15, 13:17
+1 to have it for 6.2 as well -
Christian Kuhn commented on patch set 7 CR +1 01/18/15, 22:05
Ok, this looks good on reading and digging into the sub methods. But: This method is used in the DataHandler, and I'm not entirely sure about possible side effects that may be triggered by the using code if the method now returns different stuff for the localization of pages - at least not everything is handled in an obvious manner regarding pages table in the context where this method is used in the DataHandler. -
Christian Kuhn commented on patch set 7 01/18/15, 22:08
To lower the risk of any regression in the language handling - and really, the using code is not easily overseen - I'd opt for NOT backporting this to 6.2! I'd rather merge this to master only and see if any use case may kill the language handling in DataHandler that we've not yet found. -
Christian Kuhn voted on patch set 7 CR +2 V +2 01/18/15, 22:21
-
Christian Kuhn merged patch set 7 01/18/15, 22:21