1117[BUGFIX] TCEforms palette header is only indented on first tab
Commit message
Review
-
Code review CR -1
- Steffen Kamper +2
- Xavier Perseguers +1
- Andreas Wolf -1
-
Verified V +1
- Steffen Kamper +1
- Xavier Perseguers +1
Files 1
Review log 7
-
Andreas Wolf commented on patch set 1 03/21/11, 22:06
I would prefer that you didn't submit this I can't reproduce this. Maybe this is due to the styling information in the showitem array of the table's TCA entry? For the pages table, I get the same wrapping for all tabs. I also can't remember that there is any special wrapping for tabs > 1. Could you give a concrete example where this occurs? Maybe we have to generally change the CSS definition to match all palette headers, independently of what elements they are nested in. -
Andreas Wolf commented on patch set 1 03/21/11, 22:06
Still can't reproduce this :( Please check the showitem array for the CType if there is any style string. -
Steffen Kamper commented on patch set 1 03/21/11, 22:06
Verified; Looks good to me, approved -
Steffen Kamper commented on patch set 1 03/21/11, 22:06
Andreas, i just uploaded a screenshot to mantis. It's when you place a content element on a page, view the access tab eg. -
Steffen Kamper commented on patch set 1 03/21/11, 22:06
insert a login CE to reproduce my screenshot. -
Xavier Perseguers commented on patch set 1 03/21/11, 22:06
Verified; Looks good to me, but someone else must approve Reproducible with login form at least -
Steffen Kamper merged patch set 1 03/21/11, 22:06