11225[FEATURE] BE preview for non standard SSL port
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Wouter Wolters +1
- Philipp Gampe +1
-
Verified V +2
- Christian Kuhn +2
Files 1
Review log 22
-
Christian Kuhn uploaded patch set 2 05/16/12, 17:34
-
Christian Kuhn uploaded patch set 3 05/16/12, 17:34
-
Christian Kuhn commented on patch set 4 05/16/12, 17:34
Verified; Looks good to me, but someone else must approve -
Christian Kuhn commented on patch set 4 05/16/12, 17:34
@Stefano: The rebase was done already after I fixed the whitespace issues in the class ;) -
Christian Kuhn uploaded patch set 4 05/16/12, 17:34
-
Christian Kuhn commented on patch set 4 05/16/12, 17:34
I would prefer that you didn't submit this We should also add a unit test to this one. I'll see what I can do. -
Christian Kuhn uploaded patch set 5 05/16/12, 17:34
-
Christian Kuhn commented on patch set 5 05/16/12, 17:34
The patch is pretty hard to test (for the full scenario a proper server setup is needed). Therefor, I'll now fake the sslPort value in my setup again to retest it, and will merge the patch even with the missing vote since the code itself is actually pretty obvious. -
Christian Kuhn commented on patch set 5 05/16/12, 17:34
Verified; Looks good to me, but someone else must approve Actually, this patch is pretty hard to unit test since the method itself with all its static calls is nearly impossible to feed with data. Since the patch itself is pretty easy, I think we should let it in ... -
Christian Kuhn commented on patch set 5 05/16/12, 17:34
Simple test scenario for later reference: - Have an active backend login with https:// - Set $GLOBALS['TYPO3_CONF_VARS']['BE']['lockSSLPort'] = '4711'; in localconf.php - Use 'Show' in the context menu of the page tree -> https://my.domein:4711/path... -
Stefano Kowalke commented on patch set 4 05/16/12, 17:34
I would prefer that you didn't submit this It looks more like, that this changeset based on an old repo state (one before fixing the whitespace issue in this file). As Gerrit triggers Jenkins and passes the changeset to him, Jenkins checks out the whole core on state of that changeset and apply it to the core. As result you got issues which was already fixed. You can proof this by have a look at the nightly job [1] where no DissallowSpaceIndent violation was found for this file To make it short: A simple rebase of the local repo and pushing the patch again will make Mr. Jenkins smile. [1] https://ci.typo3.org/view/TYPO3/view/Core/job/typo3-v4-core-nightly/518/checkstyleResult/file.1549038953/category.-2054143363/ -
Stefano Kowalke commented on patch set 4 05/16/12, 17:34
No score -
Stefano Kowalke commented on patch set 5 05/16/12, 17:34
As I explained already at https://review.typo3.org/#/c/11229/ there was no whitespace violations in this file. You removed whitespaces in an string, which not raise a violation of this kind. -
Philipp Gampe commented on patch set 5 05/16/12, 17:34
Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 05/16/12, 17:34
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/4047/ : FAILURE -
Mr. Jenkins commented on patch set 3 05/16/12, 17:34
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/4051/ : FAILURE -
Mr. Jenkins commented on patch set 4 05/16/12, 17:34
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4053/ : SUCCESS -
Mr. Jenkins commented on patch set 5 05/16/12, 17:34
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4057/ : SUCCESS -
Wouter Wolters commented on patch set 1 05/16/12, 17:34
(3 inline comments) See my inline comments.Also 6.0 :-)class.t3lib_befunc.php:2723Inline comments are with // and one tab in front of it.class.t3lib_befunc.php:2727Remove the tabs here -
Wouter Wolters commented on patch set 5 05/16/12, 17:34
Looks good to me, but someone else must approve -
Christian Kuhn commented on patch set 5 V 0 05/16/12, 17:34
by team member; Looks good to me, approved -
Christian Kuhn merged patch set 5 05/16/12, 17:34