Review main Merged

11245[BUGFIX] Subject field in FormWizard

Florian Scholz CR +2 V +2 Easy +17 −1 updated 06/03/13, 20:49

Commit message

Allow setting the subject of an Email
by adding a 3rd input field to the
post processor section of the form tab.

Review

  • Code review CR +2
    • Steffen Ritter +2
  • Verified V +2
    • Steffen Ritter +2

Issues 1

Files 3

Review log 14

  1. Steffen Ritter merged patch set 1 09/03/12, 16:50

  2. Philipp Gampe commented on patch set 1 09/03/12, 16:50

    I would prefer that you didn't submit this sorry, I no time for a full review currently.
    Resolves: and Release: 6.0 lines are missing,
  3. Mattias Nilsson commented on patch set 1 09/03/12, 16:50

    Verified; Looks good to me, but someone else must approve
  4. Mr. Jenkins commented on patch set 1 09/03/12, 16:50

  5. Mario Rimann commented on patch set 2 2 comments 09/03/12, 16:50

    Verified; Looks good to me, but someone else must approve I think this is a bug rather than a feature, see inline comments. Besides that: works fine, the entered subject is properly stored in the form configuration TS when saving from the wizard.
  6. Steffen Ritter uploaded patch set 3 09/03/12, 16:50

  7. Steffen Ritter commented on patch set 3 V 0 09/03/12, 16:50

    by team member; Looks good to me, approved just changed the commit message, merged after my testing
  8. Philipp Gampe commented on patch set 2 09/03/12, 16:50

    Looks good to me, but someone else must approve I can't test, because the form fails on sending the mail.
  9. Mattias Nilsson commented on patch set 2 09/03/12, 16:50

    Verified; Looks good to me, but someone else must approve
  10. Mr. Jenkins commented on patch set 2 09/03/12, 16:50

  11. Mr. Jenkins commented on patch set 3 09/03/12, 16:50

  12. Florian Scholz uploaded patch set 2 09/03/12, 16:50

  13. Florian Scholz commented on patch set 2 09/03/12, 16:50

    Bump!
  14. Wouter Wolters commented on patch set 3 09/03/12, 16:50

    Commit message is still wrong;) Form extension is not part of 4.5