11245[BUGFIX] Subject field in FormWizard
Commit message
Review
-
Code review CR +2
- Steffen Ritter +2
-
Verified V +2
- Steffen Ritter +2
Issues 1
Files 3
Review log 14
-
Steffen Ritter merged patch set 1 09/03/12, 16:50
-
Philipp Gampe commented on patch set 1 09/03/12, 16:50
I would prefer that you didn't submit this sorry, I no time for a full review currently.Resolves: and Release: 6.0 lines are missing, -
Mattias Nilsson commented on patch set 1 09/03/12, 16:50
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 09/03/12, 16:50
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4058/ : SUCCESS -
Mario Rimann commented on patch set 2 2 comments 09/03/12, 16:50
Verified; Looks good to me, but someone else must approve I think this is a bug rather than a feature, see inline comments. Besides that: works fine, the entered subject is properly stored in the form configuration TS when saving from the wizard. -
Steffen Ritter uploaded patch set 3 09/03/12, 16:50
-
Steffen Ritter commented on patch set 3 V 0 09/03/12, 16:50
by team member; Looks good to me, approved just changed the commit message, merged after my testing -
Philipp Gampe commented on patch set 2 09/03/12, 16:50
Looks good to me, but someone else must approve I can't test, because the form fails on sending the mail. -
Mattias Nilsson commented on patch set 2 09/03/12, 16:50
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 2 09/03/12, 16:50
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4109/ : SUCCESS -
Mr. Jenkins commented on patch set 3 09/03/12, 16:50
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5696/ : SUCCESS -
Florian Scholz uploaded patch set 2 09/03/12, 16:50
-
Florian Scholz commented on patch set 2 09/03/12, 16:50
Bump! -
Wouter Wolters commented on patch set 3 09/03/12, 16:50
Commit message is still wrong;) Form extension is not part of 4.5