11272[BUGFIX] Reduce CGL violations in class.tslib_fe.php
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
-
Verified V +2
- Christian Kuhn +2
Issues 1
Files 1
Review log 6
-
Oliver Klee commented on patch set 1 05/17/12, 17:33
Looks good to me, but someone else must approve There still are lots of other CGL violations in the changed lines left, but this change is one little step towards better code. -
Christian Kuhn uploaded patch set 2 05/17/12, 17:33
-
Mr. Jenkins commented on patch set 1 05/17/12, 17:33
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4086/ : SUCCESS -
Mr. Jenkins commented on patch set 2 05/17/12, 17:33
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4101/ : SUCCESS -
Christian Kuhn commented on patch set 2 V 0 05/17/12, 17:33
by team member; Looks good to me, approved Just did some minor change to the commit message, other than that I'm fine and happy with the patch. Thanks! -
Christian Kuhn merged patch set 2 05/17/12, 17:33