Review main Merged

11274[BUGFIX] Reduce CGL violations in class.tx_install.php

mostwanted CR +2 V +2 Hard +208 −208 updated 06/03/13, 20:49

Commit message

Fix/Reduce CGL violations "FunctionCallArgumentSpacingNoSpaceAfterComma"
in typo3/sysext/install/mod/class.tx_install.php.

There are over 500 violations against this rule. This is fixed/reduced.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2

Issues 1

Files 1

Review log 8

  1. Oliver Klee commented on patch set 1 05/17/12, 17:44

    Looks good to me, but someone else must approve
  2. mostwanted commented on patch set 1 05/17/12, 17:44

    Just me, myself and i! ;-) But i realized, that another strategy is necessary. i try to make some kind of "proof of concept commit" next weekend that hopefully shows that my new strategy to fix CGL violations much faster and without any risk will work.
  3. Christian Kuhn uploaded patch set 2 05/17/12, 17:44

  4. Philipp Gampe commented on patch set 1 05/17/12, 17:44

    Looks good to me, but someone else must approve How many slaves do you have?
  5. Mr. Jenkins commented on patch set 1 05/17/12, 17:44

  6. Mr. Jenkins commented on patch set 2 05/17/12, 17:44

  7. Christian Kuhn commented on patch set 2 V 0 05/17/12, 17:44

    by team member; Looks good to me, approved
  8. Christian Kuhn merged patch set 2 05/17/12, 17:44