Review TYPO3_4-5 Merged

1128[BUGFIX] Changing TCA via Tools->Configuration breaks TCA

Steffen Gebert CR +2 V +1 Easy +16 −2 updated 06/03/13, 20:49

Commit message

Changing the TCA (especially the columns-part of a table) via
Tools->Configuration breaks eg. the list module.
Tools->Configuration writes strings like
$GLOBALS['TCA']['tt_news']['columns']['image']['config']['allowed'] = 'jpg';
to typo3conf/extTables.php.

However, a call to loadTCA($table) call is not added before, so
the TCA array is incomplete. Furthermore if you set the columns part
in extTables.php any proceeding call to loadTCA will not work, since
'columns' is already defined.

Review

  • Code review CR +2
    • Steffen Gebert +2
    • Markus Klein +1
  • Verified V +1
    • Markus Klein +1
    • Steffen Gebert +1

Files 1

Review log 5

  1. Markus Klein commented on patch set 1 03/10/11, 22:05

    Should I review my own patch for 4.5 now?
  2. Markus Klein commented on patch set 1 03/10/11, 22:05

    Verified; Looks good to me, but someone else must approve
  3. Steffen Gebert commented on patch set 1 03/10/11, 22:05

    Verified; Looks good to me, approved
  4. Steffen Gebert commented on patch set 1 03/10/11, 22:05

    Would be good, if you can test it. If it works without flaws, please vote +1 Verified. Thanks!
  5. Steffen Gebert merged patch set 1 03/10/11, 22:05