1130[BUGFIX] Pagetree - Missing icons for expand/collapse whole branches
Commit message
Review
-
Code review CR +2
- Stefan Galinski +2
-
Verified V +1
- Stefan Galinski +1
Files 6
- t3lib/stddb/tables.php+4 −0
- t3lib/config_default.php+2 −0
- typo3/sysext/t3skin/images/icons/apps/pagetree-collapse.pngnewbinary
- typo3/sysext/t3skin/images/icons/apps/pagetree-expand.pngnewbinary
- typo3/sysext/t3skin/images/sprites/t3skin.pngbinary
- typo3/sysext/t3skin/stylesheets/sprites/t3skin.css+911 −903
Review log 12
-
Gerrit wrote 03/22/11, 02:46
Your change could not be merged due to a path conflict. Please merge (or rebase) the change locally and upload the resolution for review. -
Steffen Kamper commented on patch set 2 03/22/11, 02:46
Verified; Looks good to me, approved I don't like the icons very much, but better than none. -
Stefan Galinski commented on patch set 2 03/22/11, 02:46
Hi Steffen, I moved the icons to the pagetree sprite section as you mentioned. BTW: The sprite generator doesn't work with trunk anymore. -
Stefan Galinski uploaded patch set 2 03/22/11, 02:46
-
Stefan Galinski uploaded patch set 3 03/22/11, 02:46
-
Stefan Galinski commented on patch set 3 03/22/11, 02:46
Verified; Looks good to me, approved Just uploaded a new rebased patchset, because of merging errors. No other changes are made... -
Steffen Ritter commented on patch set 1 03/22/11, 02:46
I would prefer that you didn't submit this please have a look at your icon naming... there's a namepsace apps-pagetree apps-filetree etc. Furthermore such icons are already present due to TCAtree. regards Steffen -
Steffen Ritter commented on patch set 2 03/22/11, 02:46
Verified; Looks good to me, approved I'm fine with this one :) To me, I would say go on... -
Steffen Ritter commented on patch set 2 03/22/11, 02:46
FYI: I know about the spritegen in trunk... It's not about the Generator itself, it is about the extdeveval which tries to generate gifs - which is not available in 4.6 anymore... Will have to adapt this one with an version switch -
Mr. Jenkins commented on patch set 2 03/22/11, 02:46
Build Started http://ci.typo3.org/job/typo3-v4-core-gerrit/8/ -
Mr. Jenkins commented on patch set 2 V 0 03/22/11, 02:46
Build Successful SUCCESS: http://ci.typo3.org/job/typo3-v4-core-gerrit/8/ -
Stefan Galinski merged patch set 3 03/22/11, 02:46