Review main Merged

1130[BUGFIX] Pagetree - Missing icons for expand/collapse whole branches

Stefan Galinski CR +2 V +1 Expert +917 −903 updated 06/03/13, 20:49

Commit message

The expand/collapse context menu actions are missing icons.

Review

  • Code review CR +2
    • Stefan Galinski +2
  • Verified V +1
    • Stefan Galinski +1

Files 6

Review log 12

  1. Gerrit wrote 03/22/11, 02:46

    Your change could not be merged due to a path conflict. Please merge (or rebase) the change locally and upload the resolution for review.
  2. Steffen Kamper commented on patch set 2 03/22/11, 02:46

    Verified; Looks good to me, approved I don't like the icons very much, but better than none.
  3. Stefan Galinski commented on patch set 2 03/22/11, 02:46

    Hi Steffen, I moved the icons to the pagetree sprite section as you mentioned. BTW: The sprite generator doesn't work with trunk anymore.
  4. Stefan Galinski uploaded patch set 2 03/22/11, 02:46

  5. Stefan Galinski uploaded patch set 3 03/22/11, 02:46

  6. Stefan Galinski commented on patch set 3 03/22/11, 02:46

    Verified; Looks good to me, approved Just uploaded a new rebased patchset, because of merging errors. No other changes are made...
  7. Steffen Ritter commented on patch set 1 03/22/11, 02:46

    I would prefer that you didn't submit this please have a look at your icon naming... there's a namepsace apps-pagetree apps-filetree etc. Furthermore such icons are already present due to TCAtree. regards Steffen
  8. Steffen Ritter commented on patch set 2 03/22/11, 02:46

    Verified; Looks good to me, approved I'm fine with this one :) To me, I would say go on...
  9. Steffen Ritter commented on patch set 2 03/22/11, 02:46

    FYI: I know about the spritegen in trunk... It's not about the Generator itself, it is about the extdeveval which tries to generate gifs - which is not available in 4.6 anymore... Will have to adapt this one with an version switch
  10. Mr. Jenkins commented on patch set 2 03/22/11, 02:46

  11. Mr. Jenkins commented on patch set 2 V 0 03/22/11, 02:46

  12. Stefan Galinski merged patch set 3 03/22/11, 02:46