11311[BUGFIX] Reduce spacing CGL violations in /typo3/sysext/
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
-
Verified V +2
- Christian Kuhn +2
Issues 1
Files 136
- typo3/sysext/beuser/mod/index.php+93 −93
- typo3/sysext/beuser/class.tx_beuser.php+1 −1
- typo3/sysext/beuser/class.tx_beuser_switchbackuser.php+1 −1
- typo3/sysext/beuser/ext_tables.php+1 −1
- typo3/sysext/cms/layout/db_layout.php+52 −52
- typo3/sysext/cms/layout/db_new_content_el.php+15 −15
- typo3/sysext/cms/layout/wizard_backend_layout.php+2 −2
- typo3/sysext/cms/tslib/content/class.tslib_content_content.php+2 −2
- typo3/sysext/cms/tslib/media/scripts/example_callfunction.php+9 −9
- typo3/sysext/cms/tslib/media/scripts/example_itemArrayProcFunc.php+3 −3
- typo3/sysext/cms/tslib/media/scripts/example_keepRollover.php+4 −4
- typo3/sysext/cms/tslib/media/scripts/example_languageMenu.php+1 −1
- typo3/sysext/cms/tslib/media/scripts/example_typolinkpop.php+1 −1
- typo3/sysext/cms/tslib/media/scripts/fe_adminLib.inc+134 −134
- typo3/sysext/cms/tslib/media/scripts/gmenu_foldout.php+8 −8
- typo3/sysext/cms/tslib/media/scripts/gmenu_layers.php+33 −33
- typo3/sysext/cms/tslib/media/scripts/plaintextLib.inc+46 −46
- typo3/sysext/cms/tslib/media/scripts/postit.inc+7 −7
- typo3/sysext/cms/tslib/media/scripts/testscript_EXT.php+1 −1
- typo3/sysext/cms/tslib/media/scripts/tmenu_layers.php+33 −33
Show 116 more files
- typo3/sysext/cms/tslib/media/scripts/wapversionLib.inc+22 −22
- typo3/sysext/cms/tslib/media/scripts/xmlversionLib.inc+2 −2
- typo3/sysext/cms/tslib/class.tslib_feuserauth.php+21 −21
- typo3/sysext/cms/tslib/class.tslib_gifbuilder.php+59 −59
- typo3/sysext/cms/tslib/class.tslib_pagegen.php+29 −29
- typo3/sysext/cms/tslib/class.tslib_pibase.php+62 −62
- typo3/sysext/cms/tslib/class.tslib_search.php+44 −44
- typo3/sysext/cms/tslib/index_ts.php+5 −5
- typo3/sysext/cms/tslib/showpic.php+4 −4
- typo3/sysext/cms/web_info/class.tx_cms_webinfo.php+5 −5
- typo3/sysext/cms/web_info/class.tx_cms_webinfo_lang.php+14 −14
- typo3/sysext/css_styled_content/pi1/class.tx_cssstyledcontent_pi1.php+51 −51
- typo3/sysext/css_styled_content/ext_localconf.php+2 −2
- typo3/sysext/extra_page_cm_options/class.tx_extrapagecmoptions.php+5 −5
- typo3/sysext/extra_page_cm_options/ext_tables.php+1 −1
- typo3/sysext/feedit/view/class.tx_feedit_editpanel.php+4 −4
- typo3/sysext/felogin/pi1/class.tx_felogin_pi1.php+5 −5
- typo3/sysext/filelist/mod1/file_list.php+4 −4
- typo3/sysext/form/Classes/Domain/Factory/Typoscript.php+3 −3
- typo3/sysext/form/Classes/Domain/Factory/TyposcriptToJson.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/JSON/Checkboxgroup.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/JSON/Name.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/JSON/Radiogroup.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/JSON/Select.php+1 −1
- typo3/sysext/form/Classes/View/Wizard/Wizard.php+1 −1
- typo3/sysext/func/mod1/index.php+3 −3
- typo3/sysext/func_wizards/class.tx_funcwizards_webfunc.php+1 −1
- typo3/sysext/func_wizards/ext_tables.php+1 −1
- typo3/sysext/impexp/app/index.php+103 −103
- typo3/sysext/impexp/modfunc1/class.tx_impexp_modfunc1.php+7 −7
- typo3/sysext/impexp/class.tx_impexp_clickmenu.php+3 −3
- typo3/sysext/impexp/ext_tables.php+1 −1
- typo3/sysext/indexed_search/example/class.crawlerhook.php+5 −5
- typo3/sysext/indexed_search/example/class.pihook.php+2 −2
- typo3/sysext/indexed_search/hooks/class.tx_indexedsearch_tslib_fe_hook.php+1 −1
- typo3/sysext/indexed_search/mod/index.php+20 −20
- typo3/sysext/indexed_search/modfunc1/class.tx_indexedsearch_modfunc1.php+91 −91
- typo3/sysext/indexed_search/modfunc2/class.tx_indexedsearch_modfunc2.php+9 −9
- typo3/sysext/indexed_search/pi/class.tx_indexedsearch.php+188 −188
- typo3/sysext/indexed_search/class.crawler.php+71 −71
- typo3/sysext/indexed_search/class.external_parser.php+56 −56
- typo3/sysext/indexed_search/class.indexer.php+91 −91
- typo3/sysext/indexed_search/class.lexer.php+20 −20
- typo3/sysext/info/mod1/index.php+1 −1
- typo3/sysext/info_pagetsconfig/class.tx_infopagetsconfig_webinfo.php+6 −6
- typo3/sysext/info_pagetsconfig/ext_tables.php+1 −1
- typo3/sysext/install/updates/class.tx_coreupdates_compatversion.php+17 −17
- typo3/sysext/install/updates/class.tx_coreupdates_imagescols.php+1 −1
- typo3/sysext/install/updates/class.tx_coreupdates_mergeadvanced.php+1 −1
- typo3/sysext/install/updates/class.tx_coreupdates_notinmenu.php+1 −1
- typo3/sysext/install/updates/class.tx_coreupdates_t3skin.php+1 −1
- typo3/sysext/lowlevel/clmods/class.cleanflexform.php+10 −10
- typo3/sysext/lowlevel/clmods/class.deleted.php+7 −7
- typo3/sysext/lowlevel/clmods/class.double_files.php+14 −14
- typo3/sysext/lowlevel/clmods/class.lost_files.php+10 −10
- typo3/sysext/lowlevel/clmods/class.missing_files.php+8 −8
- typo3/sysext/lowlevel/clmods/class.missing_relations.php+11 −11
- typo3/sysext/lowlevel/clmods/class.orphan_records.php+9 −9
- typo3/sysext/lowlevel/clmods/class.rte_images.php+20 −20
- typo3/sysext/lowlevel/clmods/class.syslog.php+2 −2
- typo3/sysext/lowlevel/clmods/class.versions.php+28 −28
- typo3/sysext/lowlevel/config/index.php+4 −4
- typo3/sysext/lowlevel/dbint/cli/refindex_cli.php+1 −1
- typo3/sysext/lowlevel/dbint/index.php+26 −26
- typo3/sysext/lowlevel/class.tx_lowlevel_admin_core.php+4 −4
- typo3/sysext/lowlevel/class.tx_lowlevel_cleaner_core.php+51 −51
- typo3/sysext/lowlevel/ext_localconf.php+1 −1
- typo3/sysext/lowlevel/ext_tables.php+1 −1
- typo3/sysext/perm/mod1/index.php+12 −12
- typo3/sysext/recordlist/mod1/index.php+12 −12
- typo3/sysext/rtehtmlarea/hooks/softref/class.tx_rtehtmlarea_softrefproc.php+1 −1
- typo3/sysext/rtehtmlarea/mod3/browse_links.php+1 −1
- typo3/sysext/rtehtmlarea/mod3/class.tx_rtehtmlarea_browse_links.php+20 −20
- typo3/sysext/rtehtmlarea/mod4/class.tx_rtehtmlarea_select_image.php+12 −12
- typo3/sysext/rtehtmlarea/mod5/class.tx_rtehtmlarea_user.php+19 −19
- typo3/sysext/rtehtmlarea/mod6/class.tx_rtehtmlarea_parse_html.php+2 −2
- typo3/sysext/rtehtmlarea/pi2/class.tx_rtehtmlarea_pi2.php+1 −1
- typo3/sysext/rtehtmlarea/class.tx_rtehtmlarea_base.php+1 −1
- typo3/sysext/scheduler/class.tx_scheduler_module.php+1 −1
- typo3/sysext/setup/mod/index.php+4 −4
- typo3/sysext/setup/ext_tables.php+1 −1
- typo3/sysext/statictemplates/media/scripts/example_callfunction.php+9 −9
- typo3/sysext/statictemplates/media/scripts/example_itemArrayProcFunc.php+3 −3
- typo3/sysext/statictemplates/media/scripts/example_keepRollover.php+4 −4
- typo3/sysext/statictemplates/media/scripts/example_languageMenu.php+1 −1
- typo3/sysext/statictemplates/media/scripts/example_typolinkpop.php+1 −1
- typo3/sysext/statictemplates/media/scripts/fe_adminLib.inc+43 −43
- typo3/sysext/statictemplates/media/scripts/gmenu_foldout.php+8 −8
- typo3/sysext/statictemplates/media/scripts/gmenu_layers.php+33 −33
- typo3/sysext/statictemplates/media/scripts/plaintextLib.inc+8 −8
- typo3/sysext/statictemplates/media/scripts/postit.inc+7 −7
- typo3/sysext/statictemplates/media/scripts/testscript_EXT.php+1 −1
- typo3/sysext/statictemplates/media/scripts/tmenu_layers.php+33 −33
- typo3/sysext/statictemplates/media/scripts/wapversionLib.inc+20 −20
- typo3/sysext/statictemplates/media/scripts/xmlversionLib.inc+1 −1
- typo3/sysext/sv/class.tx_sv_auth.php+12 −12
- typo3/sysext/sv/class.tx_sv_authbase.php+2 −2
- typo3/sysext/sv/class.tx_sv_loginformhook.php+2 −2
- typo3/sysext/sys_action/ext_tables.php+1 −1
- typo3/sysext/sys_note/ext_tables.php+1 −1
- typo3/sysext/t3editor/classes/class.tx_t3editor.php+1 −1
- typo3/sysext/t3editor/classes/class.tx_t3editor_hooks_tstemplateinfo.php+1 −1
- typo3/sysext/tsconfig_help/mod1/index.php+56 −56
- typo3/sysext/tsconfig_help/ext_tables.php+1 −1
- typo3/sysext/tstemplate_analyzer/class.tx_tstemplateanalyzer.php+6 −6
- typo3/sysext/tstemplate_analyzer/ext_tables.php+1 −1
- typo3/sysext/tstemplate_ceditor/class.tx_tstemplateceditor.php+9 −9
- typo3/sysext/tstemplate_ceditor/ext_tables.php+1 −1
- typo3/sysext/tstemplate_info/class.tx_tstemplateinfo.php+38 −38
- typo3/sysext/tstemplate_info/ext_tables.php+1 −1
- typo3/sysext/tstemplate_objbrowser/class.tx_tstemplateobjbrowser.php+29 −29
- typo3/sysext/tstemplate_objbrowser/ext_tables.php+1 −1
- typo3/sysext/wizard_crpages/class.tx_wizardcrpages_webfunc_2.php+3 −3
- typo3/sysext/wizard_crpages/ext_tables.php+1 −1
- typo3/sysext/wizard_sortpages/class.tx_wizardsortpages_webfunc_2.php+6 −6
- typo3/sysext/wizard_sortpages/ext_tables.php+1 −1
Review log 16
-
mostwanted commented on patch set 2 05/20/12, 10:17
sure, i can do this tomorrow. -
mostwanted commented on patch set 2 05/20/12, 10:17
How can i identify 3rd party code? if you could guide me i would overwork this commit. -
mostwanted commented on patch set 2 05/20/12, 10:17
yes, this is again a systematic tab to whitespace change (my last one for this moment). -
mostwanted uploaded patch set 2 05/20/12, 10:17
-
mostwanted commented on patch set 2 05/20/12, 10:17
This fix was automated in my IDE via regex search and replace. My IDE did not indicate any php errors. Sorry for that huge commit. Please let me know if you would prefer if i split this commit into smaller chunks. -
mostwanted commented on patch set 3 05/20/12, 10:17
This fix was automated in my IDE via regex search and replace. My IDE did not indicate any php errors. this is the last automated spacing CGL violations commit of this kind from me by now. thanks for reviewing this huge commit (and all the others i pushed yesterday)! compared to patch 2 i removed 3 .diff files and 1 .txt file. i reviewed the files and i am quite sure that there are no 3rd party code files in this patch. i already removed these 3rd party code files (which were included in patch 1) in patch 2: * typo3/sysext/adodb/adodb/drivers/adodb-ado.inc.php * typo3/sysext/adodb/adodb/drivers/adodb-ado5.inc.php * typo3/sysext/indexed_search/class.doublemetaphone.php please let me know if you can still find 3rd party code files. i will remove them. -
mostwanted uploaded patch set 3 05/20/12, 10:17
-
Christian Kuhn commented on patch set 2 05/20/12, 10:17
If the patch is again a systematic tab to whitespace change I'll review and merge tomorrow. Sure, it is big and it will take some time to read it, but on the other hand it is also no fun to split it into more pieces, since the smaller parts sum up to the same volume of changes. Thus, lets stay it this way, and I'll review tomorrow. -
Christian Kuhn commented on patch set 3 V 0 05/20/12, 10:17
by team member; Looks good to me, approved -
Christian Kuhn merged patch set 3 05/20/12, 10:17
-
Stefano Kowalke commented on patch set 2 05/20/12, 10:17
I would prefer that you didn't submit this Don't change 3rd party code like * typo3/sysext/adodb/adodb/drivers/adodb-ado.inc.php * typo3/sysext/adodb/adodb/drivers/adodb-ado5.inc.php * typo3/sysext/indexed_search/class.doublemetaphone.php This stuff don't have to follow the TYPO3 CGLs and is ignored by the Codesniffer. -
Philipp Gampe commented on patch set 2 05/20/12, 10:17
could you please split this into multiple commits? (or I can do it). IMHO this 24xx changes are too much for one patch. Of course of Christian commits it, I am fine. -
Mr. Jenkins commented on patch set 1 05/20/12, 10:17
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/4131/ : FAILURE -
Mr. Jenkins commented on patch set 2 05/20/12, 10:17
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4132/ : SUCCESS -
Mr. Jenkins commented on patch set 3 05/20/12, 10:17
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4133/ : SUCCESS -
Stefano Kowalke commented on patch set 3 05/20/12, 10:17
You can identify TYPO3 / 3rd party code by the license comment at the very beginning of the file. Also all files in */lib/ folders are good candidates for non TYPO3 code.