Review main Merged

11323[BUGFIX] CGL violations FunctionCallArgumentSpacing in alt_clickmenu.php

mostwanted CR +2 V +2 Normal +92 −92 updated 06/03/13, 20:49

Commit message

Fix some CGL violations in alt_clickmenu.php against rule
"FunctionCallArgumentSpacingNoSpaceAfterComma".

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2

Issues 1

Files 1

Review log 8

  1. mostwanted commented on patch set 1 05/20/12, 13:02

    This fix was semi-automated in my IDE via regex search and manual replace. i only updated php files. My IDE did not indicate any php errors.
  2. Christian Kuhn uploaded patch set 2 05/20/12, 13:02

  3. Philipp Gampe commented on patch set 1 V 0 05/20/12, 13:02

    patch applies clean
  4. Philipp Gampe commented on patch set 1 05/20/12, 13:02

    Looks good to me, but someone else must approve
  5. Mr. Jenkins commented on patch set 1 05/20/12, 13:02

  6. Mr. Jenkins commented on patch set 2 05/20/12, 13:02

  7. Christian Kuhn commented on patch set 2 V 0 05/20/12, 13:02

    by team member; Looks good to me, approved
  8. Christian Kuhn merged patch set 2 05/20/12, 13:02