Review main Merged

1133[BUGFIX] List module - Fix pointer issue in pagebrowser

Peter Beernink CR +2 V +2 Easy +8 −8 updated 06/03/13, 20:49

Commit message

When you have more than 50 records in the list module, you can use
the page browser to display the next set of records.
When using this on the pages table, the pointer to page 2,3,.. is
added to the link of each page record. Selecting such a link causes
the result listing of that page to also start from that specific result
page. If there are not enough records, none will be shown.

Review

  • Code review CR +2
    • Susi Moog +2
  • Verified V +2
    • Susi Moog +2

Issues 1

Files 2

Review log 13

  1. Steffen Gebert commented on patch set 1 04/10/11, 12:00

    Verified; Looks good to me, but someone else must approve
  2. Susi Moog uploaded patch set 3 04/10/11, 12:00

  3. Steffen Gebert uploaded patch set 2 04/10/11, 12:00

  4. Steffen Gebert commented on patch set 2 04/10/11, 12:00

    Verified; Looks good to me, but someone else must approve Just improved the commit message.
  5. Mr. Jenkins commented on patch set 1 04/10/11, 12:00

  6. Mr. Jenkins commented on patch set 1 04/10/11, 12:00

    The build is not broken. This was just a test from me.
  7. Mr. Jenkins commented on patch set 1 04/10/11, 12:00

  8. Mr. Jenkins commented on patch set 1 V 0 04/10/11, 12:00

  9. Mr. Jenkins commented on patch set 1 04/10/11, 12:00

  10. Mr. Jenkins commented on patch set 2 04/10/11, 12:00

  11. Mr. Jenkins commented on patch set 3 04/10/11, 12:00

  12. Susi Moog commented on patch set 3 V 0 04/10/11, 12:00

    by team member; Looks good to me, approved Fixed merge conflicts and adjusted commit message issue link.
  13. Susi Moog merged patch set 3 04/10/11, 12:00