Review main Merged

11331[BUGFIX ] CGL violations FunctionCallArgumentSpacing in alt_doc.php

mostwanted CR +2 V +2 Normal +45 −45 updated 06/03/13, 20:49

Commit message

There were some violations against the CGL rule
"FunctionCallArgumentSpacingNoSpaceAfterComma" in alt_doc.php.
These will be reduced by this commit.

Review

  • Code review CR +2
    • Tolleiv Nietsch +2
    • Oliver Klee +1
  • Verified V +2
    • Tolleiv Nietsch +2

Issues 1

Files 1

Review log 11

  1. mostwanted commented on patch set 1 05/25/12, 06:46

    This fix was semi-automated in my IDE via regex search and manual replace. My IDE did not indicate any php errors.
  2. mostwanted uploaded patch set 2 05/25/12, 06:46

  3. mostwanted commented on patch set 2 05/25/12, 06:46

    OK, thanks for the tipp.
  4. Oliver Klee commented on patch set 3 05/25/12, 06:46

    Looks good to me, but someone else must approve
  5. mostwanted uploaded patch set 3 05/25/12, 06:46

  6. Christian Kuhn commented on patch set 1 05/25/12, 06:46

    I would prefer that you didn't submit this Roland, please try not to use those abbreviations in the header line. Look at the recently merged patch, I've streamlined the header line a bit to get rid of them.
  7. Mr. Jenkins commented on patch set 1 05/25/12, 06:46

  8. Mr. Jenkins commented on patch set 2 05/25/12, 06:46

  9. Mr. Jenkins commented on patch set 3 05/25/12, 06:46

  10. Tolleiv Nietsch commented on patch set 3 V 0 05/25/12, 06:46

    by team member; Looks good to me, approved
  11. Tolleiv Nietsch merged patch set 3 05/25/12, 06:46