Review main Merged

11338[BUGFIX] CGL violations FunctionCallArgument in indexed_search

mostwanted CR +2 V +2 Hard +186 −186 updated 06/03/13, 20:49

Commit message

There were some violations against the CGL rule
"FunctionCallArgumentSpacingNoSpaceAfterComma" in
indexed_search. These will be reduced by this commit.

CGL violations will be reduced in 2 files.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Oliver Klee +1
  • Verified V +2
    • Jigal van Hemert +2
    • Oliver Klee +1

Files 2

Review log 26

Show 1 earlier messages
  1. mostwanted uploaded patch set 2 05/28/12, 11:53

  1. mostwanted uploaded patch set 3 05/28/12, 11:53

  2. Markus Klein commented on patch set 4 05/28/12, 11:53

    (1 inline comment) will push new version
    superfluous space
  3. Markus Klein uploaded patch set 5 05/28/12, 11:53

  4. Markus Klein commented on patch set 5 05/28/12, 11:53

    Looks good to me, but someone else must approve
  5. Oliver Klee commented on patch set 4 05/28/12, 11:53

    Looks good to me, but someone else must approve
  6. Oliver Klee commented on patch set 5 05/28/12, 11:53

    Looks good to me, but someone else must approve
  7. mostwanted uploaded patch set 4 05/28/12, 11:53

  8. mostwanted commented on patch set 4 05/28/12, 11:53

    This fix was semi-automated in my IDE via regex search and manual replace. My IDE did not indicate any php errors.
  9. Oliver Klee commented on patch set 6 05/28/12, 11:53

    Looks good to me, but someone else must approve
  10. Oliver Klee uploaded patch set 7 05/28/12, 11:53

  11. Oliver Klee commented on patch set 7 05/28/12, 11:53

    Verified; Looks good to me, but someone else must approve Rebased to resolve merge conflicts. Tested by running the unit tests and with php -l.
  12. mostwanted uploaded patch set 6 05/28/12, 11:53

  13. mostwanted commented on patch set 6 05/28/12, 11:53

    fixed the 7 missing violations.
  14. mostwanted commented on patch set 6 05/28/12, 11:53

    8 missed violations, not 7. sorry.
  15. Jigal van Hemert commented on patch set 5 05/28/12, 11:53

    I would prefer that you didn't submit this 8 missed "violations". Haven't looked at the code that gerrit didn't show though. It's very hard to read if only one rule is done with all the other "violations" still in place.

    class.tx_indexedsearch_modfunc1.php:145

    Missed one at the end! : 0,1);

    class.tx_indexedsearch_modfunc1.php:351

    Missed one: ...</em>',$row['phash....

    class.tx_indexedsearch_modfunc1.php:1090

    Missed one at the beginning: ...UTE###',htmlspecial...

    class.tx_indexedsearch.php:303

    Missed one: ....implode(',',t3lib...

    class.tx_indexedsearch.php:747

    Missed one: ...Header($id,$section...

    class.tx_indexedsearch.php:1432

    Missed one: ...results'],$optValues...

    class.tx_indexedsearch.php:2128

    Missed two: ...linkPage($pathId,$pathStr,array...
  16. Jigal van Hemert commented on patch set 7 V 0 05/28/12, 11:53

    by team member; Looks good to me, approved
  17. Jigal van Hemert merged patch set 7 05/28/12, 11:53

  18. Mr. Jenkins commented on patch set 1 05/28/12, 11:53

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/4156/ : FAILURE
  19. Mr. Jenkins commented on patch set 3 05/28/12, 11:53

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/4158/ : FAILURE
  20. Mr. Jenkins commented on patch set 4 05/28/12, 11:53

  21. Mr. Jenkins commented on patch set 5 05/28/12, 11:53

  22. Mr. Jenkins commented on patch set 6 05/28/12, 11:53

  23. Mr. Jenkins commented on patch set 7 05/28/12, 11:53

  24. Wouter Wolters commented on patch set 5 05/28/12, 11:53

    Looks good to me, but someone else must approve
  25. Wouter Wolters commented on patch set 6 05/28/12, 11:53

    @Jigal Doing all CGL violation fixes in one patch will make the patches to big to review normally. Focussing on one CGL rule is IMHO easier to review because you have to look at one thing. See it as a pattern. This is also mentioned by other core-devs to do one CGL rule in a patch.