11341[TASK] Clean up the phpDoc of t3lib_tceforms
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Oliver Klee +1
-
Verified V +2
- Georg Ringer +2
- Oliver Klee +1
Issues 1
Files 1
Review log 24
-
Gerrit wrote 05/30/12, 02:28
Your change could not be merged due to a path conflict. Please merge (or rebase) the change locally and upload the resolution for review. -
Oliver Klee commented on patch set 1 05/30/12, 02:28
(7 inline comments)class.t3lib_tceforms.php:1157Here, the parameter names still are missing.class.t3lib_tceforms.php:2928This is commented-out code that can be removed.class.t3lib_tceforms.php:4293missing parameter nameclass.t3lib_tceforms.php:4294missing parameter nameclass.t3lib_tceforms.php:4328An -> Aclass.t3lib_tceforms.php:4415missing parameter namesclass.t3lib_tceforms.php:5109missing parameter namesclass.t3lib_tceforms.php:6413tab -> space -
Mr. Jenkins commented on patch set 1 05/30/12, 02:28
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4162/ : SUCCESS -
Oliver Klee commented on patch set 2 05/30/12, 02:28
(1 inline comment) -
Mr. Jenkins commented on patch set 2 05/30/12, 02:28
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4163/ : SUCCESS -
Wouter Wolters commented on patch set 2 05/30/12, 02:28
Thank for the review Oliver:) -
Wouter Wolters uploaded patch set 2 05/30/12, 02:28
-
Oliver Klee commented on patch set 3 05/30/12, 02:28
Looks good to me, but someone else must approve -
Oliver Klee uploaded patch set 4 05/30/12, 02:28
-
Oliver Klee commented on patch set 4 05/30/12, 02:28
Looks good to me, but someone else must approve Just rebased. -
Oliver Klee uploaded patch set 5 05/30/12, 02:28
-
Oliver Klee commented on patch set 5 05/30/12, 02:28
Verified; Looks good to me, but someone else must approve Rebased to resolve merge conflicts. Tested with php -l. -
Georg Ringer commented on patch set 3 V 0 05/30/12, 02:28
by team member; Looks good to me, approved -
Georg Ringer commented on patch set 3 05/30/12, 02:28
wanna do the rebase? -
Georg Ringer commented on patch set 4 05/30/12, 02:28
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 3 05/30/12, 02:28
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4165/ : SUCCESS -
Mr. Jenkins commented on patch set 4 05/30/12, 02:28
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4205/ : SUCCESS -
Mr. Jenkins commented on patch set 5 05/30/12, 02:28
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4245/ : SUCCESS -
Wouter Wolters commented on patch set 3 05/30/12, 02:28
Fix last inline comment. -
Wouter Wolters commented on patch set 3 05/30/12, 02:28
Anyone? -
Wouter Wolters uploaded patch set 3 05/30/12, 02:28
-
Wouter Wolters commented on patch set 3 05/30/12, 02:28
Will rebase this today. -
Georg Ringer commented on patch set 5 V 0 05/30/12, 02:28
by team member; Looks good to me, approved -
Georg Ringer merged patch set 5 05/30/12, 02:28