Review main Merged

1141[BUGFIX] TCEFORM language selector: wrong relations

Thorsten Kahler CR +2 V +2 Normal +29 −27 updated 06/03/13, 20:49

Commit message

The language selector in the top of BE forms is intended to show (and
switch between) all translations of a certain record. All records in
non-default languages, that are not bound to a record in the default
language are shown as translations of each other.
The patch adds a distinction between translated records and records in
a non-default language to render the dropdowns labels and functions.
Additionally fixes PHPDoc and indentation of SC_alt_doc::languageSwitch().

Review

  • Code review CR +2
    • Andreas Wolf +2
  • Verified V +2
    • Andreas Wolf +2

Issues 1

Files 1

Review log 20

  1. Thorsten Kahler commented on patch set 1 06/05/11, 18:40

    Steps to reproduce: 1) Create two records of the same kind (tt_content, tt_news, ...) on the same page and associate them to different languages. 2) Open one of them in the edit form. 3) Selecting the other language in the language select box at the top will open the absolutely unrelated other record.
  2. Thorsten Kahler uploaded patch set 2 06/05/11, 18:40

  3. Thorsten Kahler uploaded patch set 3 06/05/11, 18:40

  4. Thorsten Kahler commented on patch set 3 06/05/11, 18:40

    Patch wasn't changed, only bugtracker link updated.
  5. Thorsten Kahler commented on patch set 3 06/05/11, 18:40

    (1 inline comment)
  6. Thorsten Kahler uploaded patch set 4 06/05/11, 18:40

  7. Andreas Wolf uploaded patch set 5 06/05/11, 18:40

  8. Andreas Wolf commented on patch set 5 V 0 06/05/11, 18:40

    by team member; Looks good to me, approved Pushing after my review; did an additional small white space change.
  9. Andreas Wolf merged patch set 5 06/05/11, 18:40

  10. Tolleiv Nietsch commented on patch set 1 06/05/11, 18:40

    Looks good to me, but someone else must approve The patch looks good, but could you add some further information how to properly test (before / after behaviour) ?
  11. Markus Klein commented on patch set 3 06/05/11, 18:40

    Looks good to me, but someone else must approve

    alt_doc.php:1126

    Please remove tab before brace here. (CGL)
  12. Markus Klein voted on patch set 3 V 0 06/05/11, 18:40

  13. Markus Klein commented on patch set 4 06/05/11, 18:40

    Verified; Looks good to me, but someone else must approve
  14. Georg Ringer commented on patch set 4 06/05/11, 18:40

    Verified; Looks good to me, but someone else must approve
  15. Mr. Jenkins commented on patch set 1 V 0 06/05/11, 18:40

  16. Mr. Jenkins commented on patch set 1 06/05/11, 18:40

  17. Mr. Jenkins commented on patch set 2 06/05/11, 18:40

  18. Mr. Jenkins commented on patch set 3 06/05/11, 18:40

  19. Mr. Jenkins commented on patch set 4 06/05/11, 18:40

  20. Mr. Jenkins commented on patch set 5 06/05/11, 18:40