11422[BUGFIX] Fix CGL violations in index.php
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 12
-
Dmitry Dulepov commented on patch set 1 05/23/12, 18:51
Looks good to me, approved -
Markus Klein commented on patch set 1 05/23/12, 18:51
Then please add a comment explicitly stating this purpose. -
Oliver Klee commented on patch set 1 1 comment 05/23/12, 18:51
Looks good to me, but someone else must approve -
Oliver Klee commented on patch set 1 05/23/12, 18:51
I've added a patch for #37447 which adds a comment to explain why there is a require instead of require_once. -
mostwanted commented on patch set 1 05/23/12, 18:51
(1 inline comment) -
Christian Kuhn commented on patch set 1 05/23/12, 18:51
Do not submit The require is done by purpose here! This is an entry script and I want the script to fatal if it was already required. Do not remove that. -
Philipp Gampe commented on patch set 1 05/23/12, 18:51
(1 inline comment)index.php:38I think the require was on purpose. -
Philipp Gampe commented on patch set 1 05/23/12, 18:51
(1 inline comment) -
Mr. Jenkins commented on patch set 1 05/23/12, 18:51
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4178/ : SUCCESS -
Wouter Wolters commented on patch set 1 05/23/12, 18:51
(1 inline comment)index.php:38The coding guide lines say: http://forge.typo3.org/projects/team-php_codesniffer/wiki/TYPO3v4_Sniffs_with_code_examples#Including-fileindex.php:38ReplyI totally agree on that. My point here was that Roland followed the CGL. I guess that here the CGL must be ignored or the CGL rule needs to be changed. -
Wouter Wolters commented on patch set 1 05/23/12, 18:51
(1 inline comment) -
mostwanted commented on patch set 1 05/23/12, 18:51
Abandoned