Review main Abandoned

11422[BUGFIX] Fix CGL violations in index.php

mostwanted CR 0 V 0 Easy +5 −4 updated 06/03/13, 20:49

Commit message

phpcs finds 4 CGL violations in index.php. This will be fixed.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 12

  1. Dmitry Dulepov commented on patch set 1 05/23/12, 18:51

    Looks good to me, approved
  2. Markus Klein commented on patch set 1 05/23/12, 18:51

    Then please add a comment explicitly stating this purpose.
  3. Oliver Klee commented on patch set 1 1 comment 05/23/12, 18:51

    Looks good to me, but someone else must approve
  4. Oliver Klee commented on patch set 1 05/23/12, 18:51

    I've added a patch for #37447 which adds a comment to explain why there is a require instead of require_once.
  5. mostwanted commented on patch set 1 05/23/12, 18:51

    (1 inline comment)
  6. Christian Kuhn commented on patch set 1 05/23/12, 18:51

    Do not submit The require is done by purpose here! This is an entry script and I want the script to fatal if it was already required. Do not remove that.
  7. Philipp Gampe commented on patch set 1 05/23/12, 18:51

    (1 inline comment)

    index.php:38

    I think the require was on purpose.
  8. Philipp Gampe commented on patch set 1 05/23/12, 18:51

    (1 inline comment)
  9. Mr. Jenkins commented on patch set 1 05/23/12, 18:51

  10. Wouter Wolters commented on patch set 1 05/23/12, 18:51

    (1 inline comment)

    index.php:38 Reply

    I totally agree on that. My point here was that Roland followed the CGL. I guess that here the CGL must be ignored or the CGL rule needs to be changed.
  11. Wouter Wolters commented on patch set 1 05/23/12, 18:51

    (1 inline comment)
  12. mostwanted commented on patch set 1 05/23/12, 18:51

    Abandoned